Apple app ID incorrect on release builds

[RyanJarv]

Description

Brought up in brave/brave-core#319 (comment)

Release builds will have an extra dot at the end of the app id.

com.brave.Browser.

This should be (edit: fixed spelling)

com.brave.Browser

[bbondy]

com.brave.Browser right?

[bbondy]

any update on this? I mentioned the fix to @w0ts0n recently

[RyanJarv]

Not yet, not too hard of a fix just want to make sure it get's tested when it goes in. If anything is blocking this right now let me know.

[bbondy]

Test plan:
/usr/libexec/PlistBuddy -c 'Print CFBundleIdentifier' <Brave-App-Path-Here.app>/Contents/Info.plist

Should list:
com.brave.Browser.dev for dev channel
com.brave.Browser.beta for beta channel
com.brave.Browser.nightly for nightly channel

com.brave.Browser for release channel

Please check once for every channel.

[kjozwiak]

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.56.2 Chromium: 70.0.3538.35 (Official Build) dev (64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Mac OS X

Kamils-MBP:~ kjozwiak$ /usr/libexec/PlistBuddy -c 'Print CFBundleIdentifier' /Applications/Brave\ Browser\ Dev.app/Contents/Info.plist
com.brave.Browser.dev

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision	cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS	Mac OS X

Kamils-MBP:~ kjozwiak$ /usr/libexec/PlistBuddy -c 'Print CFBundleIdentifier' /Applications/Brave\ Browser\ Beta.app/Contents/Info.plist
com.brave.Browser.beta

[kjozwiak]

Once we get Release builds, will go through the same case and label as QA Pass-macOS when completed.

@LaurenWags probably a good idea if you go through @bbondy's cases on beta and dev and ensure you're getting the correct values as well as you're running a different macOS.

[LaurenWags]

Went through verification using the following build under macOS 10.12.6 x64 - PASSED

Brave	0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision	cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS	Mac OS X

Laurens-MacBook-Pro:~ laurenwagner$ /usr/libexec/PlistBuddy -c 'Print CFBundleIdentifier' /Applications/Brave\ Browser\ Beta.app/Contents/Info.plist
com.brave.Browser.beta

Brave	0.56.2 Chromium: 70.0.3538.35 (Official Build) dev (64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Mac OS X

Laurens-MacBook-Pro:~ laurenwagner$ /usr/libexec/PlistBuddy -c 'Print CFBundleIdentifier' /Applications/Brave\ Browser\ Dev.app/Contents/Info.plist
com.brave.Browser.dev

[kjozwiak]

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Mac OS X

Kamils-MBP:~ kjozwiak$ /usr/libexec/PlistBuddy -c 'Print CFBundleIdentifier' /Applications/Brave\ Browser.app/Contents/Info.plist
com.brave.Browser

• As per Apple app ID incorrect on release builds #970 (comment), ensured that there weren't any . at the end of the string