Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SaveActivityInfoList insert #9829

Closed
NejcZdovc opened this issue May 18, 2020 · 1 comment · Fixed by brave/brave-core#5594
Closed

Optimize SaveActivityInfoList insert #9829

NejcZdovc opened this issue May 18, 2020 · 1 comment · Fixed by brave/brave-core#5594

Comments

@NejcZdovc
Copy link
Contributor

https://brave.sp.backtrace.io/p/brave/triage?filters=(_deleted%3D0%2C(callstack%2Ccontains%2Cledger))&sort=(ver%2Chead%2Cdesc)&aggregations=((ver%2Chead)%2C(guid%2Cunique)%2C(classifiers%2Chead))&fingerprint=7f718b9c452857bd88fb749ecc21bfbad63a02ff12c03cac17aaecd21310b6e6

We should just create object with publisher_key, percent and weight and not whole publisher insert. We should also batch insert it with batch query

@LaurenWags
Copy link
Member

LaurenWags commented Jun 16, 2020

Verified passed with

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-06-16 at 8 55 08 AM

Screen Shot 2020-06-16 at 8 54 58 AM

Verification passed on


Brave | 1.11.78 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | Windows 10 OS Version 1903 (Build 18362.900)



Verified passed with

Brave	1.11.87 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

Screen Shot 2020-07-03 at 12 57 36 PM

Screen Shot 2020-07-03 at 12 57 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment