Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use brave-browser for source of truth for version #657

Closed
2 tasks done
bbondy opened this issue Jul 29, 2018 · 0 comments
Closed
2 tasks done

Use brave-browser for source of truth for version #657

bbondy opened this issue Jul 29, 2018 · 0 comments
Assignees
@bbondy
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jul 29, 2018

  • Use brave-browser for source of truth for version (instead of brave-core which is mounted in src/brave)
  • Warn (and fail build if in release) if package.json doesn't match the chrome/VERSION version
@bbondy bbondy self-assigned this Jul 29, 2018
@bbondy bbondy added this to the Releasable builds milestone Jul 29, 2018
bbondy added a commit that referenced this issue Jul 29, 2018
@bbondy
Use brave-browser version and check for inconsistency with src/chrome…
c63e124 
…/VERSION

Fix #657
@bbondy bbondy mentioned this issue Jul 29, 2018
Merged
9 tasks
@bbondy bbondy added the QA/No label Aug 18, 2018
@btlechowski btlechowski mentioned this issue Jun 10, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 11, 2020
Closed
@joejoejo joejoejo mentioned this issue Jun 11, 2020
Open
@kjozwiak kjozwiak mentioned this issue Jun 11, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 11, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Jun 11, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 11, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Jun 11, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Jun 11, 2020
Closed
This was referenced Jun 11, 2020
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 11, 2020
Closed
@btlechowski btlechowski mentioned this issue Jun 11, 2020
Closed
This was referenced Jun 12, 2020
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 15, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Jun 15, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 15, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Jun 15, 2020
Closed
@btlechowski btlechowski mentioned this issue Jun 15, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 15, 2020
Closed
@bridiver bridiver mentioned this issue Jun 15, 2020
Closed
@Johann999 Johann999 mentioned this issue Jun 16, 2020
Closed
@srirambv srirambv mentioned this issue Jun 16, 2020
Closed
@jorda0mega jorda0mega mentioned this issue Jun 16, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 16, 2020
Closed
This was referenced Jun 16, 2020
Closed
Open
Closed
Closed
@Heychsea Heychsea mentioned this issue Jun 16, 2020
Open
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 16, 2020
Closed
@kenherbert kenherbert mentioned this issue Jun 16, 2020
Closed
@srirambv srirambv mentioned this issue Jun 16, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Jun 16, 2020
Closed
@Brave-Matt Brave-Matt mentioned this issue Jun 16, 2020
Open
@btlechowski btlechowski mentioned this issue Jun 17, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Jun 17, 2020
Closed
6 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jun 17, 2020
Closed
@arnholm arnholm mentioned this issue Jun 17, 2020
Closed
@dentistformyeye dentistformyeye mentioned this issue Jun 17, 2020
Closed
@BerkeAras BerkeAras mentioned this issue Jun 17, 2020
Closed
@iefremov iefremov mentioned this issue Jun 18, 2020
Open
@AndriusA AndriusA mentioned this issue Jun 19, 2020
Closed
@kaushalyap kaushalyap mentioned this issue Jun 21, 2020
Closed
@btlechowski btlechowski mentioned this issue Jul 6, 2020
Closed
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@bbondy
Use brave-browser version and check for inconsistency with src/chrome…
74604ee 
…/VERSION

Fix brave/brave-browser#657
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@bbondy
Use brave-browser version and check for inconsistency with src/chrome…
b759877 
…/VERSION

Fix brave/brave-browser#657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
1 participant
@bbondy