Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Estimated bandwidth savings in NTP suggest bits rather than bytes #9915

Closed
btlechowski opened this issue May 23, 2020 · 3 comments · Fixed by brave/brave-core#5643
Closed

[Android] Estimated bandwidth savings in NTP suggest bits rather than bytes #9915

btlechowski opened this issue May 23, 2020 · 3 comments · Fixed by brave/brave-core#5643
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
Android 1.9.x Rel...

Comments

@btlechowski
Copy link

btlechowski commented May 23, 2020 •
edited
Loading

Follow up from: #8845

The notation is:
Upper case B is bytes
Lower case b is bits

The original design suggests bytes and upper case B: #7783 #8969

Steps to reproduce

  1. Browse few websites
  2. Open NTP
  3. Check Data Saved

Actual result

Lower case b is used, suggesting bits
Screenshot_20200523-041125_Brave

Expected result

The original suggests bytes and upper case B.
#7783
image
#8969
replace https with estimated data saved

Issue reproduces how often

100% repro rate

Device details

  • Install type (ARM, x86): Arm
  • Device (Phone, Tablet, Phablet): Tablet
  • Android version: 9

Brave version

BraveModernarm v1.9.74 on Samsung Galaxy Tab S5e (Android 9.0)

cc @brave/legacy_qa @karenkliu @SergeyZhukovsky @anthonypkeane @samartnik
@btlechowski btlechowski added feature/new-tab QA/Yes QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality labels May 23, 2020
@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 23, 2020
Closed
@samartnik samartnik mentioned this issue May 24, 2020
Merged
32 tasks
@samartnik samartnik added this to the 1.11.x - Nightly milestone May 25, 2020
@LaurenWags
Copy link
Member

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.9.77 BraveModernx86.apk

Screenshot_20200529-164046_1

Screenshot_20200529-164126_1

@btlechowski
Copy link
Author

Verification passed on BraveModernarm v1.9.77 on Samsung Galaxy Tab S5e (Android 9.0)
Verified on clean install
Screenshot_20200529-210009_Brave
Verified on upgrade
Screenshot_20200529-204744_Brave

@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on OnePlus 6T with Android 10 running 1.9.77 x64 stable build
image
image

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm 1.9.77.apk
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
Android 1.9.x Release
Development

Successfully merging a pull request may close this issue.

Changed label for data saved amount brave/brave-core
4 participants
@srirambv @LaurenWags @samartnik @btlechowski