Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimated bandwidth savings in NTP #7783

Closed
AndriusA opened this issue Jan 16, 2020 · 10 comments · Fixed by brave/brave-core#4229
Closed

Estimated bandwidth savings in NTP #7783

AndriusA opened this issue Jan 16, 2020 · 10 comments · Fixed by brave/brave-core#4229
Assignees
@AndriusA
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality

Comments

@AndriusA
Copy link

AndriusA commented Jan 16, 2020 •
edited
Loading

Description

NTP currently shows estimated time saving, but shields have a significant impact on bandwidth saved as well.

We have done some modelling to estimate it based on basic page load metrics and blocked resources (blog post) and could implement it to show the details in NTP as well as report as highly aggregated stats across the userbase with P3A.

Steps to Reproduce

Not applicable

Actual result:

Not applicable

Expected result:

image

Reproduces how often:

Not applicable

Brave version (brave://version info)

Not applicable

Version/Channel Information:

Not applicable

Other Additional Information:

Not applicable

Miscellaneous Information:
@AndriusA AndriusA self-assigned this Jan 16, 2020
This was referenced Jan 16, 2020
Merged
Closed
@rebron rebron added this to the 1.6.x - Nightly milestone Feb 13, 2020
@rebron rebron mentioned this issue Feb 14, 2020
Closed
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
@LaurenWags
Copy link
Member

@rebron @srirambv should this one be marked OS/Android as it's no longer on desktop per #8256 ?

@rebron rebron added the OS/Android Fixes related to Android browser functionality label Mar 24, 2020
@rebron
Copy link
Collaborator

rebron commented Mar 24, 2020

Yes just OS/Android

@LaurenWags
Copy link
Member

awesome, thanks @rebron!

@anthonypkeane anthonypkeane mentioned this issue Mar 24, 2020
Closed
This was referenced Apr 2, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Apr 3, 2020

Moving the issue to Android 1.7.x milestone as this is Android related

@srirambv
Copy link
Contributor

@samartnik could you confirm if this is part of 1.7.99 beta build or does this needs to be moved out to 1.8.x milestone?

@samartnik
Copy link
Contributor

on android it is in 1.9.x milestone, not sure about desktop

@srirambv
Copy link
Contributor

This is only on Android as per #7783 (comment). Will create a 1.9.x milestone for Android and move it

@samartnik
Copy link
Contributor

We have separate issue for android #8845
I generally don't understand it. We currently hide on desktop, bit still want it on Android?

@AndriusA
Copy link
Author

we want to re-enable it on desktop as well: #8969

It's on my todo, but not sure about correct milestones

@srirambv
Copy link
Contributor

Marking as dupe of #8845 and also desktop specific issue is done in #8969

@srirambv srirambv removed this from the Android 1.9.x Release milestone May 22, 2020
@btlechowski btlechowski mentioned this issue May 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndriusA AndriusA

Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bandwidth savings feature brave/brave-core
6 participants
@AndriusA @bbondy @rebron @srirambv @LaurenWags @samartnik