Skip to content

Commit

Permalink
[MacOS][Signing] Revert overwriting Alerts helper app id.
Browse files Browse the repository at this point in the history
Upstream fully transitioned now to helper (Alerts) and removed XPC
notification service. We should no longer mess with the identifier for
that executable.

See original change: #8755

See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731
  • Loading branch information
mkarolin committed Sep 7, 2021
1 parent e22e43b commit 67e4d05
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions script/signing_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,6 @@ def AddBravePartsForSigning(parts, config):
parts['helper-app'].options = (CodeSignOptions.RESTRICT
+ CodeSignOptions.KILL
+ CodeSignOptions.HARDENED_RUNTIME)
# Alerts helper is not being distributed with Chrome yet and, because it
# uses the same identifier as the current Alerts service, the signing fails.
# For now we can set a different identifier and then remove this change once
# the helper starts being bundled into the distribution.
parts['helper-alerts'].identifier = '{}.helper.alerts'.format(config.base_bundle_id)

return parts

Expand Down

0 comments on commit 67e4d05

Please sign in to comment.