[MacOS] Override helper-alerts identifier for signing. #8755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
added
CI/skip-android
mkarolin
force-pushed
the
maxk-fix-mac-signing
branch
2 times, most recently
from
5b149c4
to
324a92a
Compare
bridiver
reviewed
May 10, 2021
Alerts helper has been added for signing upstream but Chrome doesn't distribute it yet. Because it uses the same identifier as the current alerts service, we get a signing error. For now we'll use a different identifier for this helper and then revert once Chrome starts distributing the helper. Fixes brave/brave-browser#15731 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/56915522276f commit 56915522276f86acc55f86b143b4d7b260d6bc36 Author: Richard Knoll <knollr@chromium.org> Date: Fri Mar 5 16:07:34 2021 +0000 Introduce alert notification helper .app This adds a new helper .app on macOS to display alert notifications. This app is required to show alert style notifications as the main app can only show banner style ones and the XPC service can not use the new UNNotification APIs. Bug: 1127306
mkarolin
force-pushed
the
maxk-fix-mac-signing
branch
from
324a92a
to
be73472
Compare
mkarolin
changed the title
|
Other than the known audit deps fail this has some PyLint warnings. If fixing, we can re-run with |
|
Fixed pylint warnings. Would prefer to rerun MacOS signing to make sure I didn't break anything. |
|
Sounds good, thanks @mkarolin! |
|
Still have pylint warnings, I guess we are using python3's pylint. I was checking with python2's one. |
mihaiplesa
approved these changes
May 12, 2021
mkarolin
changed the title
mkarolin
added a commit
that referenced
this pull request
May 18, 2021
* [MacOS] Override helper-alerts identifier for signing. Alerts helper has been added for signing upstream but Chrome doesn't distribute it yet. Because it uses the same identifier as the current alerts service, we get a signing error. For now we'll use a different identifier for this helper and then revert once Chrome starts distributing the helper. Fixes brave/brave-browser#15731 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/56915522276f commit 56915522276f86acc55f86b143b4d7b260d6bc36 Author: Richard Knoll <knollr@chromium.org> Date: Fri Mar 5 16:07:34 2021 +0000 Introduce alert notification helper .app This adds a new helper .app on macOS to display alert notifications. This app is required to show alert style notifications as the main app can only show banner style ones and the XPC service can not use the new UNNotification APIs. Bug: 1127306 * Pacify pylint for signing_helper.py
mkarolin
added a commit
that referenced
this pull request
Sep 1, 2021
Upstream fully transitioned now to helper (Alerts) and removed XPC notification service. We should no longer mess with the identifier for that executable. See original change: #8755 See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731
mariospr
pushed a commit
that referenced
this pull request
Sep 3, 2021
Upstream fully transitioned now to helper (Alerts) and removed XPC notification service. We should no longer mess with the identifier for that executable. See original change: #8755 See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731
mkarolin
added a commit
that referenced
this pull request
Sep 7, 2021
Upstream fully transitioned now to helper (Alerts) and removed XPC notification service. We should no longer mess with the identifier for that executable. See original change: #8755 See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731
mkarolin
added a commit
that referenced
this pull request
Sep 11, 2021
Upstream fully transitioned now to helper (Alerts) and removed XPC notification service. We should no longer mess with the identifier for that executable. See original change: #8755 See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731
mkarolin
added a commit
that referenced
this pull request
Sep 13, 2021
Upstream fully transitioned now to helper (Alerts) and removed XPC notification service. We should no longer mess with the identifier for that executable. See original change: #8755 See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#15731
Alerts helper has been added for signing upstream but Chrome doesn't
distribute it yet. Because it uses the same identifier as the current
alerts service, we get a signing error.
For now we'll use a different identifier for this helper and then
revert once Chrome starts distributing the helper.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: