Skip to content

Commit

Permalink
Revert "[MacOS][Signing] Revert overwriting Alerts helper app id."
Browse files Browse the repository at this point in the history
This reverts commit e509b80.

Seems like we need to keep the original fix after all, since we are
getting the same signing error again:

Brave Browser Nightly.app: nested code is modified or invalid
Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework
file modified: Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework/Versions/Current/Helpers/Brave Browser Nightly Helper (Alerts).app

Fixes brave/brave-browser#18099
  • Loading branch information
mkarolin committed Sep 14, 2021
1 parent a936442 commit a0eb74a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions script/signing_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,15 @@ def AddBravePartsForSigning(parts, config):
parts['helper-app'].options = (CodeSignOptions.RESTRICT
+ CodeSignOptions.KILL
+ CodeSignOptions.HARDENED_RUNTIME)
# Alerts helper is not being distributed with Chrome yet and, because it
# uses the same identifier as the current Alerts service, the signing fails.
# For now we can set a different identifier and then remove this change once
# the helper starts being bundled into the distribution.
# Cr94 update: Alrts helper is now distributed with Chrome and the conflicting
# XPC Notification service is supposed to be gone, but we still end up with
# the signing error. So, let's keep this override and see if it causes any
# issues.
parts['helper-alerts'].identifier = '{}.helper.alerts'.format(config.base_bundle_id)

return parts

Expand Down

0 comments on commit a0eb74a

Please sign in to comment.