Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOS] Signing is failing on Nightly build due to helper (Alerts) app. #18099

Closed
mkarolin opened this issue Sep 14, 2021 · 0 comments · Fixed by brave/brave-core#10082
Closed

Comments

@mkarolin
Copy link
Contributor

After merging in cr94 (brave/brave-core#9558), which reverted the change made in brave/brave-core#8755 - because Helper (Alerts) app is now being distributed with Chrome and the XPC Notification service was removed - we ended up with the same signing error again that brave/brave-core#8755 was meant to get around.

The error is:

Brave Browser Nightly.app: nested code is modified or invalid
Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework
file modified: Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework/Versions/Current/Helpers/Brave Browser Nightly Helper (Alerts).app

Seems like we need to keep the workaround and see if that causes any issues with the alerts and/or getting a new prompt.

@mkarolin mkarolin self-assigned this Sep 14, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Sep 14, 2021
This reverts commit e509b80.

Seems like we need to keep the original fix after all, since we are
getting the same signing error again:

Brave Browser Nightly.app: nested code is modified or invalid
Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework
file modified: Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework/Versions/Current/Helpers/Brave Browser Nightly Helper (Alerts).app

Fixes brave/brave-browser#18099
@mkarolin mkarolin added this to the 1.31.x - Nightly milestone Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants