Skip to content

Commit

Permalink
[MacOS] Override helper-alerts identifier for signing.
Browse files Browse the repository at this point in the history
Alerts helper has been added for signing upstream but Chrome doesn't
distribute it yet. Because it uses the same identifier as the current
alerts service, we get a signing error.

For now we'll use a different identifier for this helper and then
revert once Chrome starts distributing the helper.

Fixes brave/brave-browser#15731

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/56915522276f

commit 56915522276f86acc55f86b143b4d7b260d6bc36
Author: Richard Knoll <knollr@chromium.org>
Date:   Fri Mar 5 16:07:34 2021 +0000

    Introduce alert notification helper .app

    This adds a new helper .app on macOS to display alert notifications.
    This app is required to show alert style notifications as the main app
    can only show banner style ones and the XPC service can not use the new
    UNNotification APIs.

    Bug: 1127306
  • Loading branch information
mkarolin committed May 10, 2021
1 parent ab419e3 commit be73472
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion script/signing_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,14 @@ def AddBravePartsForSigning(parts, config):

# Overwrite to avoid TeamID mismatch with widevine dylib.
parts['helper-app'].entitlements = 'helper-entitlements.plist'
parts['helper-app'].options = CodeSignOptions.RESTRICT + CodeSignOptions.KILL + CodeSignOptions.HARDENED_RUNTIME
parts['helper-app'].options = (CodeSignOptions.RESTRICT
+ CodeSignOptions.KILL
+ CodeSignOptions.HARDENED_RUNTIME)
# Alerts helper is not being distributed with Chrome yet and, because it
# uses the same identifier as the current Alerts service, the signing fails.
# For now we can set a different identifier and then remove this change once
# the helper starts being bundled into the distribution.
parts['helper-alerts'].identifier = '{}.helper.alerts'.format(config.base_bundle_id)

return parts

Expand Down

0 comments on commit be73472

Please sign in to comment.