Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MacOS] Signing is failing on Nightly build due to helper (Alerts) app. #15731

Closed
mkarolin opened this issue May 10, 2021 · 0 comments · Fixed by brave/brave-core#8755
Closed

[MacOS] Signing is failing on Nightly build due to helper (Alerts) app. #15731

mkarolin opened this issue May 10, 2021 · 0 comments · Fixed by brave/brave-core#8755
Assignees
@mkarolin
Labels
dev-concern OS/Desktop OS/macOS QA/No release-notes/exclude
Milestone
1.25.x - Release

Comments

@mkarolin
Copy link
Contributor

After updating the master branch to cr91, building Nightly fails with:

Brave Browser Nightly.app: nested code is modified or invalid
Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework
file modified: Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework/Versions/Current/Helpers/Brave Browser Nightly Helper (Alerts).app
@mkarolin mkarolin self-assigned this May 10, 2021
mkarolin added a commit to brave/brave-core that referenced this issue May 10, 2021
@mkarolin
[MacOS] Override helper-alerts identifier for signing.
be73472 
Alerts helper has been added for signing upstream but Chrome doesn't
distribute it yet. Because it uses the same identifier as the current
alerts service, we get a signing error.

For now we'll use a different identifier for this helper and then
revert once Chrome starts distributing the helper.

Fixes brave/brave-browser#15731

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/56915522276f

commit 56915522276f86acc55f86b143b4d7b260d6bc36
Author: Richard Knoll <knollr@chromium.org>
Date:   Fri Mar 5 16:07:34 2021 +0000

    Introduce alert notification helper .app

    This adds a new helper .app on macOS to display alert notifications.
    This app is required to show alert style notifications as the main app
    can only show banner style ones and the XPC service can not use the new
    UNNotification APIs.

    Bug: 1127306
This was referenced May 10, 2021
Merged
Merged
mihaiplesa pushed a commit to brave/brave-core that referenced this issue May 12, 2021
@mkarolin
[MacOS] Override helper-alerts entitlements for signing. (#8755)
5525543 
* [MacOS] Override helper-alerts identifier for signing.

Alerts helper has been added for signing upstream but Chrome doesn't
distribute it yet. Because it uses the same identifier as the current
alerts service, we get a signing error.

For now we'll use a different identifier for this helper and then
revert once Chrome starts distributing the helper.

Fixes brave/brave-browser#15731

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/56915522276f

commit 56915522276f86acc55f86b143b4d7b260d6bc36
Author: Richard Knoll <knollr@chromium.org>
Date:   Fri Mar 5 16:07:34 2021 +0000

    Introduce alert notification helper .app

    This adds a new helper .app on macOS to display alert notifications.
    This app is required to show alert style notifications as the main app
    can only show banner style ones and the XPC service can not use the new
    UNNotification APIs.

    Bug: 1127306

* Pacify pylint for signing_helper.py
@mihaiplesa mihaiplesa added this to the 1.26.x - Nightly milestone May 12, 2021
mkarolin added a commit to brave/brave-core that referenced this issue May 18, 2021
@mkarolin
[MacOS] Override helper-alerts entitlements for signing. (#8755)
f5f9b45 
* [MacOS] Override helper-alerts identifier for signing.

Alerts helper has been added for signing upstream but Chrome doesn't
distribute it yet. Because it uses the same identifier as the current
alerts service, we get a signing error.

For now we'll use a different identifier for this helper and then
revert once Chrome starts distributing the helper.

Fixes brave/brave-browser#15731

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/56915522276f

commit 56915522276f86acc55f86b143b4d7b260d6bc36
Author: Richard Knoll <knollr@chromium.org>
Date:   Fri Mar 5 16:07:34 2021 +0000

    Introduce alert notification helper .app

    This adds a new helper .app on macOS to display alert notifications.
    This app is required to show alert style notifications as the main app
    can only show banner style ones and the XPC service can not use the new
    UNNotification APIs.

    Bug: 1127306

* Pacify pylint for signing_helper.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern OS/Desktop OS/macOS QA/No release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

[MacOS] Override helper-alerts identifier for signing. brave/brave-core
3 participants
@mihaiplesa @kjozwiak @mkarolin