Merge pull request #9807 from brave/maxk-cr93fu-enable-kEnablePasswor…

…dsAccountStorage

[cr93 followup] Removed disablement of kEnablePasswordsAccountStorage.

app/brave_main_delegate.cc

@@ -233,7 +233,6 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
     net::features::kFirstPartySets.name,
     network::features::kTrustTokens.name,
     network_time::kNetworkTimeServiceQuerying.name,
-    password_manager::features::kEnablePasswordsAccountStorage.name,
     reading_list::switches::kReadLater.name,
 #if defined(OS_ANDROID)
     features::kWebNfc.name,

app/brave_main_delegate_browsertest.cc

@@ -93,7 +93,6 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
       &net::features::kFirstPartySets,
       &network::features::kTrustTokens,
       &network_time::kNetworkTimeServiceQuerying,
-      &password_manager::features::kEnablePasswordsAccountStorage,
       &reading_list::switches::kReadLater,
   };
 

chromium_src/components/password_manager/core/browser/sync_credentials_filter.cc

@@ -0,0 +1,22 @@
+/* Copyright (c) 2021 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "components/password_manager/core/browser/sync_credentials_filter.h"
+
+#define ShouldSave ShouldSave_ChromiumImpl
+#include "../../../../../../components/password_manager/core/browser/sync_credentials_filter.cc"
+#undef ShouldSave
+
+namespace password_manager {
+
+bool SyncCredentialsFilter::ShouldSave(const PasswordForm& form) const {
+  bool should_save = ShouldSave_ChromiumImpl(form);
+  if (!should_save && sync_util::IsGaiaCredentialPage(form.signon_realm)) {
+    return true;
+  }
+  return should_save;
+}
+
+}  // namespace password_manager

chromium_src/components/password_manager/core/browser/sync_credentials_filter.h

@@ -0,0 +1,19 @@
+/* Copyright (c) 2021 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#ifndef BRAVE_CHROMIUM_SRC_COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SYNC_CREDENTIALS_FILTER_H_
+#define BRAVE_CHROMIUM_SRC_COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SYNC_CREDENTIALS_FILTER_H_
+
+#include "components/password_manager/core/browser/credentials_filter.h"
+
+#define ShouldSave                                         \
+  ShouldSave_ChromiumImpl(const PasswordForm& form) const; \
+  bool ShouldSave
+
+#include "../../../../../../components/password_manager/core/browser/sync_credentials_filter.h"
+
+#undef ShouldSave
+
+#endif  // BRAVE_CHROMIUM_SRC_COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SYNC_CREDENTIALS_FILTER_H_