Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cr93 followup] Removed disablement of kEnablePasswordsAccountStorage. #9807

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Aug 20, 2021

Fixes brave/brave-browser#17595

This feature flag no longer works as all the code it wasn't guarding has
been removed and password account storage is the only option now.

This also means that we will regress on
brave/brave-browser#16926 again, and needs a different fix added here in a separate commit.

Chromium issue:

https://bugs.chromium.org/p/chromium/issues/detail?id=1108738

https://chromium.googlesource.com/chromium/src.git/+/90ac58cb2c56df119ca3d5631cbbc3feabb8a82b

commit 90ac58cb2c56df119ca3d5631cbbc3feabb8a82b
Author: Marc Treib treib@chromium.org
Date: Fri Jul 9 10:43:20 2021 +0000

B4P cleanup, part 2: Delete old Save/Update bubble

PasswordSaveUpdateView has been replaced by
PasswordSaveUpdateWithAccountStoreView, similar for the corresponding
controller. This CL deletes the old, non-AccountStore versions.

This is a no-op on Win/Mac/Linux/ChromeOS (which already always used
the new versions) and on Android/iOS (which don't use this UI at all).
(Note that ChromeOS doesn't actually use/support the account-scoped
storage, since the signed-in non-syncing state doesn't exist. But the
new UI code is a strict superset of the old, so using it on ChromeOS as
well is just simpler and more consistent - and this was already the
case.)

This CL also ports some recent unit test improvements (see
crrev.com/c/3006215) from the old to the new controller.

Bug: 1108738

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Aug 20, 2021
@mkarolin mkarolin requested a review from fmarier August 20, 2021 18:09
@mkarolin mkarolin requested a review from a team as a code owner August 20, 2021 19:21
This feature flag no longer works as all the code it wasn't guarding has
been removed and password account storage is the only option now.

This also means that we will regress on
brave/brave-browser#16926 again, but this can
be addressed in a different fix.

Chromium issue:

https://bugs.chromium.org/p/chromium/issues/detail?id=1108738

https://chromium.googlesource.com/chromium/src.git/+/90ac58cb2c56df119ca3d5631cbbc3feabb8a82b

commit 90ac58cb2c56df119ca3d5631cbbc3feabb8a82b
Author: Marc Treib <treib@chromium.org>
Date:   Fri Jul 9 10:43:20 2021 +0000

    B4P cleanup, part 2: Delete old Save/Update bubble

    PasswordSaveUpdateView has been replaced by
    PasswordSaveUpdateWithAccountStoreView, similar for the corresponding
    controller. This CL deletes the old, non-AccountStore versions.

    This is a no-op on Win/Mac/Linux/ChromeOS (which already always used
    the new versions) and on Android/iOS (which don't use this UI at all).
    (Note that ChromeOS doesn't actually use/support the account-scoped
    storage, since the signed-in non-syncing state doesn't exist. But the
    new UI code is a strict superset of the old, so using it on ChromeOS as
    well is just simpler and more consistent - and this was already the
    case.)

    This CL also ports some recent unit test improvements (see
    crrev.com/c/3006215) from the old to the new controller.

    Bug: 1108738
Goes around upstream check for gaia credential page and empty primary
account in the browser.

Fixes brave/brave-browser#17595
Fixes brave/brave-browser#16926
@mkarolin mkarolin force-pushed the maxk-cr93fu-enable-kEnablePasswordsAccountStorage branch from e233a56 to d454b1a Compare August 24, 2021 18:57

bool SyncCredentialsFilter::ShouldSave(const PasswordForm& form) const {
bool should_save = ShouldSave_ChromiumImpl(form);
if (!should_save && sync_util::IsGaiaCredentialPage(form.signon_realm)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this does both the login page and the change password page. That looks okay to me.

@bsclifton bsclifton merged commit f6a98aa into master Aug 25, 2021
@bsclifton bsclifton deleted the maxk-cr93fu-enable-kEnablePasswordsAccountStorage branch August 25, 2021 22:20
@bsclifton bsclifton added this to the 1.30.x - Nightly milestone Aug 25, 2021
mkarolin pushed a commit that referenced this pull request Aug 25, 2021
…dsAccountStorage

[cr93 followup] Removed disablement of kEnablePasswordsAccountStorage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCHECK fails in save_update_with_account_store_bubble_controller.cc.
3 participants