Add Brave shields #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
force-pushed
the
shields
branch
3 times, most recently
from
d7cd94a
to
50645f7
Compare
bbondy
force-pushed
the
shields
branch
8 times, most recently
from
daa9b72
to
55cd96d
Compare
bbondy
force-pushed
the
shields
branch
2 times, most recently
from
a757f83
to
1abaf8d
Compare
mariospr
added a commit
that referenced
this pull request
Mar 23, 2022
BraveMainDelegate::BasicStartupComplete() is where several features are enabled and disabled for Brave via command line switches, but that method is not being called when running usptream tests, which use ChromeMainDelegate instead. Because of this, all browser tests crash on DCHECK-enabled builds with a backtrace like the following one: [497557:497557:1221/135319.265636:FATAL:distiller_javascript_utils.cc(41)] Check failed: distiller_javascript_world_id != invalid_world_id. #0 0x7fd8cc5b7459 base::debug::CollectStackTrace() #1 0x7fd8cc4b12d3 base::debug::StackTrace::StackTrace() #2 0x7fd8cc4d3a34 logging::LogMessage::~LogMessage() #3 0x7fd8cc4d44ae logging::LogMessage::~LogMessage() #4 0x56550ee1de70 dom_distiller::RunIsolatedJavaScript() #5 0x56550fffc990 brave_ads::AdsTabHelper::RunIsolatedJavaScript() #6 0x7fd8c6332b3d content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #7 0x7fd8c63531a9 content::WebContentsImpl::DocumentOnLoadCompleted() [...] #56 0x56550ccba27a _start Task trace: #0 0x7fd8c6c6ebee IPC::(anonymous namespace)::ChannelAssociatedGroupController::Accept() #1 0x7fd8cbce69df mojo::SimpleWatcher::Context::Notify() Crash keys: "ui_scheduler_async_stack" = "0x7FD8C6C6EBEE 0x7FD8CBCE69DF" "io_scheduler_async_stack" = "0x7FD8CBCE69DF 0x0" [1/1] TabStripBrowsertest.ShiftGroupLeft_OtherGroup (CRASHED) This is because the DOM Distiller feature is not enabled as expected (for Brave) on startup, and when AdsTabHelper::RunIsolatedJavaScript() (called via the WebContentsObserver machinery) calls dom_distiller::RunIsolatedJavaScript() it will fail the DCHECK that makes sure the JS World ID is already set. To fix this, we move the code of BraveMainDelegate::BasicStartupComplete() to ChromeMainDelegate::BasicStartupComplete() via a chromium_src override, so that we make sure that exactly the same initialization done for Brave and Brave-related browser tests also applies when running upstrem browser tests. This does not only fix that crash, but also makes sure that upstream browser tests are run with the same features as Brave, which is the right thing to do.
25 tasks
25 tasks
25 tasks
This was referenced Nov 10, 2023
vadimstruts
added a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Vadym Struts <vstruts@brave.com>
vadimstruts
added a commit
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Vadym Struts <vstruts@brave.com>
vadimstruts
added a commit
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Vadym Struts <vstruts@brave.com>
vadimstruts
added a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Vadym Struts <vstruts@brave.com>
vadimstruts
added a commit
that referenced
this pull request
Jun 28, 2024
Signed-off-by: Vadym Struts <vstruts@brave.com>
vadimstruts
added a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Vadym Struts <vstruts@brave.com>
vadimstruts
added a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: Vadym Struts <vstruts@brave.com>
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.