-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESLint]: Add ESLint license check. #15817
Conversation
16d9265
to
df47d07
Compare
While we haven't been doing that consistently at Brave, the correct headers now use the HTTPS URL:
So I'd suggest this:
Instead of #1, we could also just upgrade the existing ones, but that's not really necessary. |
552cbc8
to
4c1fdbe
Compare
@fmarier it should use |
@petemill for @brave/js-deps-reviewers The changes to the files in rewards-client & crypto-wallets-front-end should just be updating or adding missing license headers. Note: The build is failing for merge conflicts - I'm not going to fix them until we're ready to land this as we keep getting new ones. |
4c1fdbe
to
b7ac399
Compare
We can probably bypass most of those owner reviews since we're not making any code changes. |
b7ac399
to
5b9c43a
Compare
5b9c43a
to
a308071
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this complex issue and writing an eslint plugin from scratch to accomplish it! Nice work. Hope the rebase isn't too bad.
a308071
to
4bfe598
Compare
Doing an admin merge - things should be good to go and there are just too many reviewer groups (as this touches a lot of files; but only licensing). |
Resolves brave/brave-browser#26575
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on