Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #2016 from brave/sync_dont_send_bookmarks_when_no_… #2052

Merged

Conversation

AlexeyBarabash
Copy link
Contributor

…chain

This is uplift request of #2016 into 0.63.x

Fixes brave/brave-browser#3777 (Sync: not all bookmarks synced).
Fixes brave/brave-browser#3509 (Bookmarks are synced when not connected to sync chain).
Fixes brave/brave-browser#2687 (Sync sends bookmarks even when chain is not fully created).

For #3509 and #2687 fix is obvious.
For #3777 description is brave/brave-browser#3777 (comment).

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Use STR from
brave/brave-browser#3777
brave/brave-browser#3509
brave/brave-browser#2687

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

…chain

Sync dont send bookmarks when no chain
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AlexeyBarabash
Copy link
Contributor Author

Checked, it works on nightly build.

@AlexeyBarabash AlexeyBarabash merged commit 44583d2 into 0.63.x Mar 29, 2019
@bbondy bbondy added this to the 0.63.x - Beta milestone Mar 31, 2019
@AlexeyBarabash AlexeyBarabash deleted the sync_dont_send_bookmarks_when_no_chain_0.63.x branch April 4, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants