Use brave theme type as a system dark mode on Windows (uplift to 0.66.x) #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
simonhong
force-pushed
the
pr2352_align_brave_theme_with_native_theme_on_windows_0.66.x
branch
from
a523aea
to
81cf6dc
Compare
simonhong
force-pushed
the
pr2352_align_brave_theme_with_native_theme_on_windows_0.66.x
branch
from
81cf6dc
to
8ff3153
Compare
kjozwiak
approved these changes
May 27, 2019
There was a problem hiding this comment.
Uplift to 0.66.x approved after deliberating with the @brave/uplift-approvers team. @simonhong can you please double check and make sure that both the jenkins and travis failures are not related to this specific PR? Also, please ensure that all the correct labels are being used and all appropriate issues are moved into the correct milestone.
simonhong
deleted the
pr2352_align_brave_theme_with_native_theme_on_windows_0.66.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #2352