Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brave theme type as a system dark mode on Windows (uplift to 0.65.x) #2410

Conversation

brave-builds
Copy link
Collaborator

Uplift of #2352

@brave-builds brave-builds self-assigned this May 10, 2019
@brave-builds brave-builds added this to the 0.65.x - Beta milestone May 10, 2019
@simonhong simonhong force-pushed the pr2352_align_brave_theme_with_native_theme_on_windows_0.65.x branch 2 times, most recently from 3a25a5e to ac0470c Compare May 12, 2019 21:47
@simonhong
Copy link
Member

simonhong commented May 13, 2019

This PR is failed by version mismatch like below.
I think it should be 0.65.90 because I rebased onto latest `0.65.x1 and chrome-VERSION.patch file is also for that.

09:54:28  Version files do not match!
09:54:28  src/chrome/VERSION: 0.65.88
09:54:28  brave-browser package.json version: 0.65.90

@bsclifton How can I solve this? I run Builder many times with wipe out workspace but no difference.

@simonhong simonhong force-pushed the pr2352_align_brave_theme_with_native_theme_on_windows_0.65.x branch from ac0470c to 55f9fd9 Compare May 15, 2019 08:39
@simonhong simonhong force-pushed the pr2352_align_brave_theme_with_native_theme_on_windows_0.65.x branch from 55f9fd9 to 5afd17d Compare May 22, 2019 08:59
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.65.x denied after deliberating with the @brave/uplift-approvers team. We're getting pretty close to the 0.65.x release and this introduces a lot of changes. The general rule for uplifting into the beta channel is critical regressions, security issues or anything that really needs to get into beta. Both https://github.com/brave/brave-browser/issues/4056 and https://github.com/brave/brave-browser/issues/4272 are labelled as P3and https://github.com/brave/brave-browser/issues/3804 is labelled asP5`. @simonhong if you any questions or concerns regarding the above, please let me know!

@kjozwiak kjozwiak removed this from the 0.65.x - Beta milestone May 27, 2019
@kjozwiak kjozwiak closed this May 27, 2019
@simonhong simonhong deleted the pr2352_align_brave_theme_with_native_theme_on_windows_0.65.x branch May 28, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants