-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTP: Tweak spacing on topsites removal notification #4668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but thanks for the fix otherwise and apologies for breaking this! CI looks a bit weird, so I kicked it off again, though this is such a minimal css change 🤷♂
components/brave_new_tab_ui/components/default/notification/index.ts
Outdated
Show resolved
Hide resolved
CI looks good (Linux browser test had intermittent failure for autoplay test) except for iOS. Going to re-run only iOS |
…dex.ts Accepting per review feedback Co-Authored-By: Pete Miller <miller.pete@gmail.com>
Verification PASSED
|
Close brave/brave-browser#8282
Resolves
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See screenshot attached.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.