Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: Tweak spacing on topsites removal notification (uplift to 1.5.x) #4798

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 2, 2020

Uplift of #4668
Fixes brave/brave-browser#8282

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Mar 2, 2020
@brave-builds brave-builds added this to the 1.5.x - Beta milestone Mar 2, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv March 2, 2020 06:11
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any failures. QA went through the PR as per #4668 (comment).

Please make sure that all the needed labels are being used and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit d22cb24 into 1.5.x Mar 2, 2020
@bsclifton bsclifton deleted the pr4668_ca-8282_1.5.x branch March 2, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants