Binance widget no longer disconnects when offline. #5275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… offline Fixes brave/brave-browser#9254 - Fixes convert time issues when going offline
ryanml
commented
Apr 16, 2020
| @@ -387,7 +387,11 @@ class NewTabPage extends React.Component<Props, State> { | |||
|
|
|||
| fetchBalance = () => { | |||
| chrome.binance.getAccountBalances((balances: Record<string, string>, success: boolean) => { | |||
| if (!success) { | |||
| const hasBalances = Object.keys(balances).length | |||
There was a problem hiding this comment.
This will always be empty ({}) in an offline response. Also, we shouldn't set auth to invalid if balances simply just don't come in anyway. The success parameter is the correct thing to go off of for that.
bbondy
approved these changes
Apr 16, 2020
4 tasks
bsclifton
pushed a commit
that referenced
this pull request
Apr 21, 2020
Binance widget no longer disconnects when offline.
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also by consequence convert timers reset appropriately when dropping network connection.
Fixes: brave/brave-browser#9254
Fixes: brave/brave-browser#9253
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Defined in issues.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.