Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget looses connect state when network is disconnected #9253

Closed
srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5275
Closed

Widget looses connect state when network is disconnected #9253

srirambv opened this issue Apr 16, 2020 · 1 comment · Fixed by brave/brave-core#5275

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 16, 2020

Description

Widget looses connect state when network is disconnected

Steps to Reproduce

  1. Connect widget to Binance account
  2. Go to convert tab and enter the amount to convert
  3. Disconnect network while preview conversion countdown is shown
  4. Wait for convert preview to auto close
  5. Repeat steps 2 and 3 again
  6. Widget gets disconnected automatically

Actual result:

Widget looses connect state when network is disconnected

Expected result:

Only disconnect when user selects its via menu

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1909 (Build 18363.778)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified network state doesn't disconnect the widget

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified network state doesn't disconnect the widget

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified network state doesn't disconnect the widget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment