Make shields settings persist #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
make_plugin_contents_type_persist
branch
2 times, most recently
from
940d796
to
6d6369a
Compare
simonhong
changed the title
For now, this test is failed. Need to make this test pass.
BravePrefProvider and BraveEphemeralProvider make shields configuration persistent.
bbondy
reviewed
Oct 4, 2018
| IsShieldsResourceID(resource_identifier)) { | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we have a DCHECK here to ensure resource_identifier is empty?
I think that will prevent a future bug when we add a new content setting type and forget to add it in the list of IsShieldsResourceID
bbondy
reviewed
Oct 4, 2018
| const ResourceIdentifier& resource_identifier, | ||
| base::Value* in_value) { | ||
| // Flash type shouldn't be handled here. Its id is empty. | ||
| // It's type is plugin and id is empty string. |
There was a problem hiding this comment.
I think this comment has some redundancy with "Its id is empty" and " id is empty string" making the reader think there are 2 ids, but I think there is only one.
BraveEphemeralProvider should not handle shield settings.
simonhong
force-pushed
the
make_plugin_contents_type_persist
branch
from
e02f6f5
to
e652fc6
Compare
bbondy
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, shields settings are reset after reboot because plugin content type isn't persisted by default.(except default setting).
Our new BravePrefProvider and BraveEphemeralProvider handles to store our plugin type settings to disk.
Close brave/brave-browser#1364
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
yarn test brave_browser_tests --filter=BraveShieldsAPIBrowserTest.ShieldsSettingsPersistTest`Reviewer Checklist: