Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make shields settings persist #558

Merged
merged 4 commits into from
Oct 4, 2018
Merged

Make shields settings persist #558

merged 4 commits into from
Oct 4, 2018

Commits on Oct 4, 2018

  1. Add ShieldSettingsPersistTest 

    For now, this test is failed.
Need to make this test pass.
    @simonhong
    simonhong committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    811d060 View commit details
    Browse the repository at this point in the history

  2. Makes shields configuration persist across sesstions 

    BravePrefProvider and BraveEphemeralProvider make shields configuration
persistent.
    @simonhong
    simonhong committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    582f2a2 View commit details
    Browse the repository at this point in the history

  3. Add more test to check flash configuration isn't persisted

    @simonhong
    simonhong committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    b5d769b View commit details
    Browse the repository at this point in the history

  4. Add more DCHECKs to BraveEphemeralProvider 

    BraveEphemeralProvider should not handle shield settings.
    @simonhong
    simonhong committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    e652fc6 View commit details
    Browse the repository at this point in the history