Fixes split one time tip

[NejcZdovc]

Resolves brave/brave-browser#10153

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

defined in the issue

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[emerick]

LGTM, just one minor comment

[emerick]

LGTM

[NejcZdovc]

CI failed on test-install, all good

[LaurenWags]

Verification completed using

Brave | 1.12.11 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | macOS Version 10.14.6 (Build 18G3020)

Scenario 1 (as originally reported in issue):

• Verified STR from [Desktop] split scenarios are not contributing BAT as expected brave-browser#10153:

pre-req: have a staging wallet which was funded anonymously previously w/ BAT - should have a decent amount

1. Launch clean profile w/ flags /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --enable-logging=stderr --vmodule=*/bat-native-ledger/*=6,*/brave_rewards/*=6 --log-level=2 --rewards=staging=true --brave-ads-staging
2. Enable Rewards
3. Claim UGP grant (30 BAT).
4. Restore the wallet, note balance (should be at least 20 BAT)

note - here is my Balance info from brave://rewards-internals prior to the tip for reference:

5. Tip kjozwiakstaging.github.io 50 BAT.
6. Give the tip a bit of time to process.
7. Confirmed ending wallet balance was as expected:

8. Confirmed Balance info on brave://rewards-internals was as expected (all Rewards BAT used for tip and remaining was deducted from Deposited BAT):

9. Confirmed Tips panel shows what I would expect for tip (it is broken into 2 due to the 2 different funding sources):

10. Confirmed Monthly Statement shows what I would expect for the tip (it is broken into 2 due to the 2 different funding sources):

Encountered and logged brave/brave-browser#10176 - after restarting the browser a portion of the tip contributes again.

---

Scenario 2: (same funding sources as scenario 1, but recurring tip instead of one time tip)
pre-req: have a staging wallet which was funded anonymously previously w/ BAT - should have a decent amount

1. Launch clean profile w/ flags /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --enable-logging=stderr --vmodule=*/bat-native-ledger/*=6,*/brave_rewards/*=6 --log-level=2 --rewards=staging=true,reconcile-interval=10 --brave-ads-staging
2. Enable Rewards
3. Claim UGP grant (30 BAT).
4. Restore the wallet, note balance (should be at least 20 BAT)

note - here is my Balance info from brave://rewards-internals prior to the tip for reference:

5. Set up monthly tip to kjozwiakstaging.github.io 50 BAT. (leave AC table empty)
6. Wait for recurring tip to contribute
7. Confirmed ending wallet balance was as expected:

8. Confirmed Balance info on brave://rewards-internals was as expected (all Rewards BAT used for tip and remaining was deducted from Deposited BAT):

9. Confirmed Monthly Contributions panel shows what I would expect for recurring tip:

10. Confirmed Monthly Statement shows what I would expect for the tip (it is broken into 2 due to the 2 different funding sources):

11. Restart the browser (ensuring enough time before next short reconcile due to flag used on initial launch). Confirmed a portion of the tip was not contributed again.

---

Scenario 3 (same as scenario 1 but with different funding source):
pre-req: have a staging wallet which was funded anonymously previously w/ BAT - should have a decent amount

1. Launch clean profile w/ flags /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --enable-logging=stderr --vmodule=*/bat-native-ledger/*=6,*/brave_rewards/*=6 --log-level=2 --rewards=staging=true --brave-ads-staging
2. Enable Rewards
3. Claim UGP grant (30 BAT).
4. Connect a KYC'd uphold wallet, note balance (should be at least 20 BAT)

note - here is my Balance info from brave://rewards-internals prior to the tip for reference:

5. Tip kjozwiakstaging.github.io 50 BAT.
6. Give the tip a bit of time to process.
7. Confirmed ending wallet balance was as expected:

8. Confirmed Balance info on brave://rewards-internals was as expected (all Rewards BAT used for tip and remaining was deducted from Deposited BAT):

9. Confirmed Tips panel shows what I would expect for tip (it is broken into 2 due to the 2 different funding sources):

10. Confirmed Monthly Statement shows what I would expect for the tip (it is broken into 2 due to the 2 different funding sources):

11. Confirmed Uphold portion of the tip (20 BAT) shows in Uphold acct activity:

Encountered brave/brave-browser#10176 - after restarting the browser a portion of the tip contributes again.

---

Scenario 4 (same as scenario 3 but with tipping a non-KYC'd, verified publisher):
pre-req: have a staging wallet which was funded anonymously previously w/ BAT - should have a decent amount

1. Launch clean profile w/ flags /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --enable-logging=stderr --vmodule=*/bat-native-ledger/*=6,*/brave_rewards/*=6 --log-level=2 --rewards=staging=true --brave-ads-staging
2. Enable Rewards
3. Claim UGP grant (30 BAT).
4. Connect a KYC'd uphold wallet, note balance (should be at least 20 BAT)
5. Tip duckduckgo.com 10 BAT.
6. Tip duckduckgo.com 1 BAT.
7. Tip duckduckgo.com 10 BAT. (your remaining UGP grant balance is now 9 BAT, you can check this on brave://rewards-internals)
8. Tip duckduckgo.com 10 BAT again.
9. Confirmed only VG grant balance was used to tip DDG, the remaining amount (1 BAT) which would have come from Uphold was sent to pending tip as expected:

Encountered brave/brave-browser#10176 - after restarting the browser the Uphold portion of the tip tries to contribute, but is sent to pending list.