[Desktop] split scenarios are not contributing BAT as expected

[LaurenWags]

Description

If you have a scenario where you go to tip a publisher and your tip is funded via more than one source (sources are VG, previously deposited BAT, Uphold), the tip is not being performed correctly.

Steps to Reproduce

pre-req: have a staging wallet which was funded anonymously previously w/ BAT - should have a decent amount

1. Launch clean profile w/ flags --enable-logging=stderr --vmodule=*rewards*=6 --log-level=2 --rewards=staging=true --brave-ads-staging
2. Enable Rewards
3. Restore the wallet, note balance (should be at least 20 BAT)
4. Claim UGP grant (30 BAT)

note - here is my brave://rewards-internals prior to the tip for reference - pay attention to the Balance Info section:

5. Tip kjozwiakstaging.github.io 50 BAT.
6. Give the tip a bit of time to process.

Actual result:

--> ending balance was not correct (it was only 29 BAT less than original balance, should have be 50 BAT less)
--> looking at brave://rewards internals after waiting a bit, not all of the UGP BAT was used but it should have been
--> Tips panel shows what I would expect for tips, but Monthly Statement does not. Monthly statement doesn't seem to match the expected values.

Expected result:

brave://rewards-internals, brave://rewards tips panel, monthly statement, DB should all be in sync but they are not - there are varying values all over the place

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision	94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @rebron @brave/legacy_qa

[GeetaSarvadnya]

Reproduced in Windows 10 x64 - 1.10.87

[LaurenWags]

This should be fixed in the next 1.10.x build 👍 waiting on CI to finish for the uplifts.

[GeetaSarvadnya]

one more scenario wherein split scenarios are not contributing correctly

• Clean profile - staging env brave.exe --enable-logging --vmodule=*rewards*=6 --log-level=2 --rewards=staging=true
• Enable rewards and connect KYC'd uphold wallet
• Make sure KYC'd wallet should have 20 BAT balance
• Claim UGP grants of 30 BAT
• Send 20 BAT one-time tip to Laurenwags.github.io (20 BAT was taken from UGP grants)
• 20 BAT one-time tip was successful, 20 BAT is reduced from wallet balance, 20 BAT one time tip shown correctly in summary, statement, and tips panel.
• Send again 20 BAT one-time tip to Laurenwags.github.io (Remaining 10 BAT UGP +10 BAT from uphold)
• Wallet balance is 20 BAT instead of 10 BAT
• one time tip is shown as 40 BAT in both summary and panel but in statement it's just 30 BAT
  

seeing the same actual result what @LaurenWags mentioned above

[LaurenWags]

Verified passed with

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified STR from description
• Confirmed tip is recorded in UI and in DB

Verification passed on

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified STR from the description
• Confirmed tip is recorded in UI and in DB
  
  
  
  
  
  

Verification passed on

Brave	1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision	326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS	Ubuntu 18.04 LTS

Verified test plan from the description