Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display social links in the tip dialog that have invalid URLs #6918

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#12214

Submitter Checklist:

Test Plan:

Test plan in issue description.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@zenparsing zenparsing requested a review from a team October 21, 2020 17:57
@zenparsing zenparsing self-assigned this Oct 21, 2020
@zenparsing zenparsing requested review from emerick and NejcZdovc and removed request for a team October 21, 2020 17:57
@zenparsing zenparsing requested a review from a team as a code owner October 21, 2020 18:56
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing added this to the 1.18.x - Nightly milestone Oct 22, 2020
@zenparsing zenparsing merged commit 62385fc into master Oct 22, 2020
@zenparsing zenparsing deleted the ksmith-tip-dialog-bad-links branch October 22, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on Twitter favicon in tipping banner redirects to an error page
3 participants