Click on Twitter favicon in tipping banner redirects to an error page

[GeetaSarvadnya]

Description

Click on twitter favicon in tipping banner redirects to an error page

Steps to Reproduce

1. Clean profile 1.17.x
2. Enable rewards
3. Open https://twitter.com/jonathansampson
4. Open BR panel and click on Send tip
5. Click on Twitter favicon in tipping banner

Actual result:

Click on twitter favicon in tipping banner redirects to an error page

Expected result:

should not show any error message

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.17.42 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
Revision	002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS	Windows 10 OS Version 1903 (Build 18362.1082)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @NejcZdovc

[NejcZdovc]

this is not regression as the same thing happens for me on previous versions

[GeetaSarvadnya]

@NejcZdovc I am getting an empty screen in Release channel 1.15.x

[NejcZdovc]

yes I get empty screen as well. Problem is that link that we get from server doesn't have https in front and because of that it will not open correctly. Checking with publisher team what to do

[zenparsing]

It seems reasonable to not display a social media link if the link is not a valid absolute URL. What do you think @NejcZdovc?

[NejcZdovc]

@zenparsing that would work yup. We should also fix it on publisher side

[GeetaSarvadnya]

Verification passed on

Brave | 1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

• Verified the STR from the description
• Verified social media links are removed from tipping banners as per Click on Twitter favicon in tipping banner redirects to an error page #12214 (comment)

• Verified social media links are shown on the banner where links are redirecting to valid URL. which will fulfill the Click on Twitter favicon in tipping banner redirects to an error page #12214 (comment)
  

---

Verified passed with

Brave	1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified STR from description

Reproduced the issue using 1.17.x

Confirmed visiting same publisher on 1.18.x did not show the favicons.

Confirmed visiting a publisher with valid URLs in their favicons did show the favicons. Clicking on the favicon directed me to the expected URL.

---

Verification passed on

Brave	1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description

• Verified social media links are removed from tipping banners as per Click on Twitter favicon in tipping banner redirects to an error page #12214 (comment)
  

• Verified social media links are shown on the banner where links are redirecting to valid URL. which will fulfill the