Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added show tabs search btn option in settings #9570

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Jul 27, 2021

Resolves brave/brave-browser#16007

Needs a patch to become a friend class to access private member tab_strip_

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@nullhook nullhook force-pushed the feature/toggle-search-tab-btn branch 4 times, most recently from 444af12 to f5139f3 Compare July 28, 2021 22:22
browser/ui/views/frame/brave_browser_view.cc Outdated Show resolved Hide resolved
browser/ui/views/frame/brave_browser_view.cc Outdated Show resolved Hide resolved
browser/ui/views/frame/brave_browser_view.h Outdated Show resolved Hide resolved
browser/ui/views/frame/brave_browser_view.cc Outdated Show resolved Hide resolved
browser/ui/views/frame/brave_browser_view.cc Outdated Show resolved Hide resolved
@nullhook nullhook force-pushed the feature/toggle-search-tab-btn branch from f5139f3 to 599e168 Compare July 29, 2021 00:32
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@nullhook nullhook force-pushed the feature/toggle-search-tab-btn branch 3 times, most recently from c6e3b06 to 7b9fd73 Compare July 31, 2021 03:13
@nullhook nullhook force-pushed the feature/toggle-search-tab-btn branch from 7b9fd73 to 36832a0 Compare July 31, 2021 03:33
@nullhook nullhook requested a review from mkarolin July 31, 2021 19:39
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src ++

@nullhook nullhook merged commit 31d2b44 into master Aug 2, 2021
@nullhook nullhook deleted the feature/toggle-search-tab-btn branch August 2, 2021 16:21
@nullhook nullhook added this to the 1.29.x - Nightly milestone Aug 2, 2021
@petemill petemill removed the bug label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting to enable/disable search tabs button
6 participants