-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added show tabs search btn option in settings #9570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullhook
force-pushed
the
feature/toggle-search-tab-btn
branch
from
July 27, 2021 20:33
725d195
to
a9d1039
Compare
petemill
force-pushed
the
feature/toggle-search-tab-btn
branch
from
July 27, 2021 20:55
a9d1039
to
bfba4ec
Compare
simonhong
reviewed
Jul 27, 2021
kkuehlz
reviewed
Jul 28, 2021
bsclifton
reviewed
Jul 28, 2021
nullhook
force-pushed
the
feature/toggle-search-tab-btn
branch
4 times, most recently
from
July 28, 2021 22:22
444af12
to
f5139f3
Compare
simonhong
reviewed
Jul 28, 2021
nullhook
force-pushed
the
feature/toggle-search-tab-btn
branch
from
July 29, 2021 00:32
f5139f3
to
599e168
Compare
simonhong
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
mkarolin
reviewed
Jul 29, 2021
nullhook
force-pushed
the
feature/toggle-search-tab-btn
branch
3 times, most recently
from
July 31, 2021 03:13
c6e3b06
to
7b9fd73
Compare
nullhook
force-pushed
the
feature/toggle-search-tab-btn
branch
from
July 31, 2021 03:33
7b9fd73
to
36832a0
Compare
mkarolin
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#16007
Needs a patch to become a friend class to access private member
tab_strip_
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: