Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr93 followup] Removed disablement of kEnablePasswordsAccountStorage. #9807

Merged
merged 2 commits into from
Aug 25, 2021
Merged

[cr93 followup] Removed disablement of kEnablePasswordsAccountStorage. #9807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8869517
[cr93 followup] Removed disablement of kEnablePasswordsAccountStorage.
mkarolin Aug 20, 2021
d454b1a
Allow offering to save google passwords.
mkarolin Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/brave_main_delegate.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
net::features::kFirstPartySets.name,
network::features::kTrustTokens.name,
network_time::kNetworkTimeServiceQuerying.name,
password_manager::features::kEnablePasswordsAccountStorage.name,
reading_list::switches::kReadLater.name,
#if defined(OS_ANDROID)
features::kWebNfc.name,
Expand Down
1 change: 0 additions & 1 deletion app/brave_main_delegate_browsertest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&net::features::kFirstPartySets,
&network::features::kTrustTokens,
&network_time::kNetworkTimeServiceQuerying,
&password_manager::features::kEnablePasswordsAccountStorage,
&reading_list::switches::kReadLater,
};

Expand Down
22 changes: 22 additions & 0 deletions chromium_src/components/password_manager/core/browser/sync_credentials_filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/* Copyright (c) 2021 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "components/password_manager/core/browser/sync_credentials_filter.h"

#define ShouldSave ShouldSave_ChromiumImpl
#include "../../../../../../components/password_manager/core/browser/sync_credentials_filter.cc"
#undef ShouldSave

namespace password_manager {

bool SyncCredentialsFilter::ShouldSave(const PasswordForm& form) const {
bool should_save = ShouldSave_ChromiumImpl(form);
if (!should_save && sync_util::IsGaiaCredentialPage(form.signon_realm)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this does both the login page and the change password page. That looks okay to me.

return true;
}
return should_save;
}

} // namespace password_manager
19 changes: 19 additions & 0 deletions chromium_src/components/password_manager/core/browser/sync_credentials_filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/* Copyright (c) 2021 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

#ifndef BRAVE_CHROMIUM_SRC_COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SYNC_CREDENTIALS_FILTER_H_
#define BRAVE_CHROMIUM_SRC_COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SYNC_CREDENTIALS_FILTER_H_

#include "components/password_manager/core/browser/credentials_filter.h"

#define ShouldSave \
ShouldSave_ChromiumImpl(const PasswordForm& form) const; \
bool ShouldSave

#include "../../../../../../components/password_manager/core/browser/sync_credentials_filter.h"

#undef ShouldSave

#endif // BRAVE_CHROMIUM_SRC_COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_SYNC_CREDENTIALS_FILTER_H_