Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclickable button on Rewards NTP widget #9823

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#17572

The notification wrapper, even if empty, was being rendered into the CSS grid as a transparent element overlaying the widget content.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing self-assigned this Aug 23, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit ff02006 into master Aug 23, 2021
@zenparsing zenparsing deleted the ksmith-rewards-ntp-grid branch August 23, 2021 19:01
mkarolin pushed a commit that referenced this pull request Aug 24, 2021
Fix unclickable button on Rewards NTP widget
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.30.44 Chromium: 93.0.4577.51 (Official Build) nightly (x86_64)
Revision 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launched Brave
  3. loaded a new-tab page
  4. clicked on the Start using Rewards button on the widget
  5. confirmed that Brave Rewards was enabled

rewards-button-click

@stephendonner stephendonner added this to the 1.30.x - Nightly milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start using Rewards button in Brave Rewards NTP widget isn't clickable
3 participants