Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclickable button on Rewards NTP widget #9823

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix unclickable button on Rewards NTP widget #9823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/brave_new_tab_ui/components/default/rewards/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,12 @@ class Rewards extends React.PureComponent<RewardsProps, {}> {
// only show a single notification from any source.
// For now, this only happens for the branded wallpaper notification.
promotions = singleOrphaned ? [] : (promotions || [])

// Do not display the notification wrapper if there are no notifications.
if (promotions.length === 0 && !this.props.showBrandedWallpaperNotification) {
return null
}

const Wrapper = singleOrphaned ? React.Fragment : NotificationsList
return (
<Wrapper>
Expand Down