Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes follow up to #17670: Blocking parent-child segment will also block parent segment #9912

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Fixes follow up to #17670: Blocking parent-child segment will also block parent segment #9912

merged 1 commit into from
Aug 31, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 30, 2021 •
edited
Loading

Resolves brave/brave-browser#17738

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#17738. however, we should also run regression tests around the:

  • serving of ad notifications and inline content ads
  • purchase intent segments and ad delivery
  • epsilon greedy bandit segments and ad delivery

@tmancey tmancey self-assigned this Aug 30, 2021
@tmancey tmancey force-pushed the issues/17738 branch 12 times, most recently from 3a31be0 to 353f592 Compare August 31, 2021 16:34
moritzhaller
moritzhaller approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/17738 branch 2 times, most recently from 3eb6a5f to 3e99be1 Compare August 31, 2021 17:41
@tmancey tmancey merged commit cd95c54 into master Aug 31, 2021
@tmancey tmancey deleted the issues/17738 branch August 31, 2021 21:26
@tmancey tmancey added this to the 1.31.x - Nightly milestone Aug 31, 2021
@tmancey tmancey mentioned this pull request Aug 31, 2021
Merged
4 tasks
@btlechowski
Copy link

Verification passed on

Brave 1.31.12 Chromium: 93.0.4577.58 (Official Build) nightly (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Ubuntu 18.04 LTS

Verified technology & computing-software ad was shown and user was paid for it

[10083:10083:0901/183220.959559:VERBOSE1:eligible_ad_notifications.cc(90)] Get eligible ads for parent-child segments:
[10083:10083:0901/183220.959704:VERBOSE1:eligible_ad_notifications.cc(92)]   technology & computing-software
[10083:10083:0901/183220.959788:VERBOSE1:eligible_ad_notifications.cc(92)]   personal finance-personal finance
[10083:10083:0901/183220.959851:VERBOSE1:eligible_ad_notifications.cc(92)]   home-appliances
[10083:10083:0901/183220.967149:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[10083:10083:0901/183220.967515:VERBOSE1:ad_notification_serving.cc(126)] Found 1 eligible ads
[10083:10083:0901/183220.967606:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: c35df3d2-a09e-476b-b665-bb8ce5fc0dfc
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  advertiserId: 8d2f4191-b76e-4369-8983-3d9ff551c5ad
  segment: technology & computing-software
  title: technology & computing-software
  body: technology & computing-software
  targetUrl: https://www.brave.com
[10083:10083:0901/183221.027294:VERBOSE1:ads_service_impl.cc(1969)] Timeout ad notification with uuid c35df3d2-a09e-476b-b665-bb8ce5fc0dfc in 120 seconds
[10083:10083:0901/183221.027715:VERBOSE3:ad_notification_event_served.cc(25)] Served ad notification with uuid c35df3d2-a09e-476b-b665-bb8ce5fc0dfc and creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6
[10083:10083:0901/183221.027881:VERBOSE1:ad_notification_serving.cc(137)] Served ad notification
[10083:10083:0901/183221.036582:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid c35df3d2-a09e-476b-b665-bb8ce5fc0dfc and creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6
[10083:10083:0901/183221.036956:VERBOSE1:confirmations.cc(91)] Confirming view ad for creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6
[10083:10083:0901/183221.040317:VERBOSE1:redeem_unblinded_token.cc(51)] Redeem unblinded token
[10083:10083:0901/183221.040387:VERBOSE1:redeem_unblinded_token.cc(65)] CreateConfirmation
[10083:10083:0901/183221.040442:VERBOSE2:redeem_unblinded_token.cc(66)] POST /v1/confirmation/{confirmation_id}/{credential}
[10083:10083:0901/183221.040471:VERBOSE5:redeem_unblinded_token.cc(70)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0340d83a-edeb-456a-8282-a4185c864b1f/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiQnE4V2Z3MjdnbEo1UGVWZlhrRzVSUFpWekNDSnlJclNZdFo2cVRqRk9rWT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCIzMGVjZDcwZi1mNTZkLTQ3NDUtYTQ1Ny00MDM1ZmNhYjU0YjZcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6Im1USklQQ21nRTl4TWErRzRCQ1A4akZuVDFmL1UrUCtlaHh4eVJwSDNhN081YXZBb2xmQ1lLZk1pT1d3bjFKVDlWaVZqZE1MTTlxbVp5ekZLckd2ek1BPT0iLCJ0Ijoid3Z6c1FKUFNZb2dXQXoyZHBmSjBxeVdkbVNoSzhUTVVTSjFMRm51bUJOcnNpK2wyczNmY25iMUxwVjZEOUdya21QamltN3Y1TkN2dmc2TEFHMTBMcGc9PSJ9
  Content: {"blindedPaymentToken":"Bq8Wfw27glJ5PeVfXkG5RPZVzCCJyIrSYtZ6qTjFOkY=","buildChannel":"nightly","creativeInstanceId":"30ecd70f-f56d-4745-a457-4035fcab54b6","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[10083:10083:0901/183221.056209:VERBOSE1:ad_notification_event_served.cc(33)] Successfully logged ad notification served event
[10083:10083:0901/183221.072206:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[10083:10083:0901/183221.498087:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[10083:10083:0901/183221.498547:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0340d83a-edeb-456a-8282-a4185c864b1f/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiQnE4V2Z3MjdnbEo1UGVWZlhrRzVSUFpWekNDSnlJclNZdFo2cVRqRk9rWT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCIzMGVjZDcwZi1mNTZkLTQ3NDUtYTQ1Ny00MDM1ZmNhYjU0YjZcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6Im1USklQQ21nRTl4TWErRzRCQ1A4akZuVDFmL1UrUCtlaHh4eVJwSDNhN081YXZBb2xmQ1lLZk1pT1d3bjFKVDlWaVZqZE1MTTlxbVp5ekZLckd2ek1BPT0iLCJ0Ijoid3Z6c1FKUFNZb2dXQXoyZHBmSjBxeVdkbVNoSzhUTVVTSjFMRm51bUJOcnNpK2wyczNmY25iMUxwVjZEOUdya21QamltN3Y1TkN2dmc2TEFHMTBMcGc9PSJ9
  Response Status Code: 201
  Response: {"id":"0340d83a-edeb-456a-8282-a4185c864b1f","payload":{},"createdAt":"2021-09-01T16:32:21.613Z","type":"view","modifiedAt":"2021-09-01T16:32:21.613Z","creativeInstanceId":"30ecd70f-f56d-4745-a457-4035fcab54b6"}
[10083:10083:0901/183221.498627:VERBOSE1:redeem_unblinded_token.cc(113)] FetchPaymentToken
[10083:10083:0901/183221.498697:VERBOSE2:redeem_unblinded_token.cc(114)] GET /v1/confirmation/{confirmation_id}/paymentToken
[10083:10083:0901/183221.498724:VERBOSE5:redeem_unblinded_token.cc(118)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0340d83a-edeb-456a-8282-a4185c864b1f/paymentToken
  Method: kGet
[10083:10083:0901/183221.771018:VERBOSE1:redeem_unblinded_token.cc(129)] OnFetchPaymentToken
[10083:10083:0901/183221.771556:VERBOSE6:redeem_unblinded_token.cc(131)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0340d83a-edeb-456a-8282-a4185c864b1f/paymentToken
  Response Status Code: 200
  Response: {"id":"0340d83a-edeb-456a-8282-a4185c864b1f","createdAt":"2021-09-01T16:32:21.613Z","type":"view","modifiedAt":"2021-09-01T16:32:21.635Z","creativeInstanceId":"30ecd70f-f56d-4745-a457-4035fcab54b6","paymentToken":{"publicKey":"CrQLMWmUuYog6Q93nScS8Lo1HHSex8WM2Qxij7qhjkQ=","batchProof":"P6+0+mDCu8yaqEDgx6pWuRdFL3iauCm8Aq5of7LEhgXZHp9LR7L2M/DsR8OqrfbTS2LmVyoeAm7iU3aXxuZIDQ==","signedTokens":["UrW1bmg4Sgy51ONCXwn7ltSS0nhljSzf79j13nT7zR8="]}}
[10083:10083:0901/183221.771643:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id 0340d83a-edeb-456a-8282-a4185c864b1f, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and view
[10083:10083:0901/183221.773269:VERBOSE1:confirmations.cc(274)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

Verified technology & computing-software ad was blocked in ads history
image

Verified technology & computing ad was shown and user was paid for it

[10612:10612:0901/185812.507976:VERBOSE1:eligible_ad_notifications.cc(90)] Get eligible ads for parent-child segments:
[10612:10612:0901/185812.508273:VERBOSE1:eligible_ad_notifications.cc(92)]   personal finance-personal finance
[10612:10612:0901/185812.508451:VERBOSE1:eligible_ad_notifications.cc(92)]   home-appliances
[10612:10612:0901/185812.508634:VERBOSE1:eligible_ad_notifications.cc(92)]   food & drink-vegetarian
[10612:10612:0901/185812.509687:VERBOSE1:eligible_ad_notifications.cc(103)] No eligible ads for parent-child segments
[10612:10612:0901/185812.509845:VERBOSE1:eligible_ad_notifications.cc(124)] Get eligible ads for parent segments:
[10612:10612:0901/185812.509970:VERBOSE1:eligible_ad_notifications.cc(126)]   technology & computing
[10612:10612:0901/185812.510131:VERBOSE1:eligible_ad_notifications.cc(126)]   personal finance
[10612:10612:0901/185812.510252:VERBOSE1:eligible_ad_notifications.cc(126)]   home
[10612:10612:0901/185812.512109:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[10612:10612:0901/185812.512215:VERBOSE1:client.cc(482)] Resetting seen ad_notification advertisers
[10612:10612:0901/185812.516142:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[10612:10612:0901/185812.516612:VERBOSE1:ad_notification_serving.cc(126)] Found 1 eligible ads
[10612:10612:0901/185812.516710:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: 7be211de-61ec-41a5-b444-7024c1b199a9
  creativeInstanceId: ed6c467a-8643-42eb-a7cd-32e878fa3cd4
  creativeSetId: a9f0b49c-3298-4c1b-a8b5-76a71e8d7332
  campaignId: 0e70c893-b0c0-4dab-860d-7e65446f0f0f
  advertiserId: 8d2f4191-b76e-4369-8983-3d9ff551c5ad
  segment: technology & computing
  title: technology & computing
  body: technology & computing
  targetUrl: https://www.brave.com
[10612:10612:0901/185812.556307:VERBOSE1:ads_service_impl.cc(1969)] Timeout ad notification with uuid 7be211de-61ec-41a5-b444-7024c1b199a9 in 120 seconds
[10612:10612:0901/185812.556723:VERBOSE3:ad_notification_event_served.cc(25)] Served ad notification with uuid 7be211de-61ec-41a5-b444-7024c1b199a9 and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[10612:10612:0901/185812.558705:VERBOSE1:ad_notification_serving.cc(137)] Served ad notification
[10612:10612:0901/185812.563251:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 7be211de-61ec-41a5-b444-7024c1b199a9 and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[10612:10612:0901/185812.564593:VERBOSE1:confirmations.cc(91)] Confirming view ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[10612:10612:0901/185812.568759:VERBOSE1:redeem_unblinded_token.cc(51)] Redeem unblinded token
[10612:10612:0901/185812.568933:VERBOSE1:redeem_unblinded_token.cc(65)] CreateConfirmation
[10612:10612:0901/185812.569134:VERBOSE2:redeem_unblinded_token.cc(66)] POST /v1/confirmation/{confirmation_id}/{credential}
[10612:10612:0901/185812.569533:VERBOSE5:redeem_unblinded_token.cc(70)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0749118a-2945-43a2-aca7-7b6d753ed23a/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiTUZXMFdpOFNnZURRU0cydWo4L3dtYU9odVNYSWJ4WHVYWEFBeTJBQmpTVT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlZDZjNDY3YS04NjQzLTQyZWItYTdjZC0zMmU4NzhmYTNjZDRcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6IlRSU216TSsvS0hFSHYwM2VmaDlSUUh3MDlEQlNUTjltQnJIZGpMM1dyQmxTR3JsWWF3NDdjMUdWUDNXZXI3SFArTEtZNHpNLzNLT2tLZldzckcxR09nPT0iLCJ0IjoibStVR29uU2FFeTY2YWZsQVl3TmdJb3d4UjJGZU1tYzBRaGFZU1A2ektmdkNTZE1ONU5XOWl4L0J3RFZ3dmxMWFhsOUhQRTBhTnRMbDJyWGVaNU9DTWc9PSJ9
  Content: {"blindedPaymentToken":"MFW0Wi8SgeDQSG2uj8/wmaOhuSXIbxXuXXAAy2ABjSU=","buildChannel":"nightly","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[10612:10612:0901/185812.578212:VERBOSE1:ad_notification_event_served.cc(33)] Successfully logged ad notification served event
[10612:10612:0901/185812.579812:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[10612:10612:0901/185812.980458:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[10612:10612:0901/185812.980519:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0749118a-2945-43a2-aca7-7b6d753ed23a/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiTUZXMFdpOFNnZURRU0cydWo4L3dtYU9odVNYSWJ4WHVYWEFBeTJBQmpTVT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCJlZDZjNDY3YS04NjQzLTQyZWItYTdjZC0zMmU4NzhmYTNjZDRcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6IlRSU216TSsvS0hFSHYwM2VmaDlSUUh3MDlEQlNUTjltQnJIZGpMM1dyQmxTR3JsWWF3NDdjMUdWUDNXZXI3SFArTEtZNHpNLzNLT2tLZldzckcxR09nPT0iLCJ0IjoibStVR29uU2FFeTY2YWZsQVl3TmdJb3d4UjJGZU1tYzBRaGFZU1A2ektmdkNTZE1ONU5XOWl4L0J3RFZ3dmxMWFhsOUhQRTBhTnRMbDJyWGVaNU9DTWc9PSJ9
  Response Status Code: 201
  Response: {"id":"0749118a-2945-43a2-aca7-7b6d753ed23a","payload":{},"createdAt":"2021-09-01T16:38:21.660Z","type":"view","modifiedAt":"2021-09-01T16:38:21.660Z","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4"}
[10612:10612:0901/185812.980767:VERBOSE1:redeem_unblinded_token.cc(113)] FetchPaymentToken
[10612:10612:0901/185812.980931:VERBOSE2:redeem_unblinded_token.cc(114)] GET /v1/confirmation/{confirmation_id}/paymentToken
[10612:10612:0901/185812.980978:VERBOSE5:redeem_unblinded_token.cc(118)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0749118a-2945-43a2-aca7-7b6d753ed23a/paymentToken
  Method: kGet
[10612:10612:0901/185813.243377:VERBOSE1:redeem_unblinded_token.cc(129)] OnFetchPaymentToken
[10612:10612:0901/185813.243661:VERBOSE6:redeem_unblinded_token.cc(131)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/0749118a-2945-43a2-aca7-7b6d753ed23a/paymentToken
  Response Status Code: 200
  Response: {"id":"0749118a-2945-43a2-aca7-7b6d753ed23a","createdAt":"2021-09-01T16:38:21.660Z","type":"view","modifiedAt":"2021-09-01T16:38:21.682Z","creativeInstanceId":"ed6c467a-8643-42eb-a7cd-32e878fa3cd4","paymentToken":{"publicKey":"CrQLMWmUuYog6Q93nScS8Lo1HHSex8WM2Qxij7qhjkQ=","batchProof":"JYiOtKo2DP9O6ywq1khqz5wV3Qvnp0CyYh9/Zi2ong+auoiYjpOx3Mycn0//3DbSwfetqJrZF8qS6jftn3LfCA==","signedTokens":["UOmKBX19ULjifEQIqV19rBhJKpExwx+EP06b436XJwc="]}}
[10612:10612:0901/185813.243826:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id 0749118a-2945-43a2-aca7-7b6d753ed23a, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and view
[10612:10612:0901/185813.244564:VERBOSE1:confirmations.cc(274)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

Verified technology & computing-software and technology & computing ads were blocked in ads history
image

Verified technology & computing-software and technology & computing are not present

[11087:11087:0901/185113.443372:VERBOSE1:eligible_ad_notifications.cc(90)] Get eligible ads for parent-child segments:
[11087:11087:0901/185113.443467:VERBOSE1:eligible_ad_notifications.cc(92)]   personal finance-personal finance
[11087:11087:0901/185113.443614:VERBOSE1:eligible_ad_notifications.cc(92)]   home-appliances
[11087:11087:0901/185113.443684:VERBOSE1:eligible_ad_notifications.cc(92)]   food & drink-vegetarian
[11087:11087:0901/185113.452348:VERBOSE1:eligible_ad_notifications.cc(103)] No eligible ads for parent-child segments
[11087:11087:0901/185113.452408:VERBOSE1:eligible_ad_notifications.cc(124)] Get eligible ads for parent segments:
[11087:11087:0901/185113.452450:VERBOSE1:eligible_ad_notifications.cc(126)]   personal finance
[11087:11087:0901/185113.452474:VERBOSE1:eligible_ad_notifications.cc(126)]   home
[11087:11087:0901/185113.452508:VERBOSE1:eligible_ad_notifications.cc(126)]   food & drink

Verified technology & computing ad was blocked in ads history
image

Verified technology & computing-software and technology & computing are not present

[13478:13478:0901/214417.853697:VERBOSE1:eligible_ad_notifications.cc(90)] Get eligible ads for parent-child segments:
[13478:13478:0901/214417.853872:VERBOSE1:eligible_ad_notifications.cc(92)]   personal finance-personal finance
[13478:13478:0901/214417.853921:VERBOSE1:eligible_ad_notifications.cc(92)]   home-appliances
[13478:13478:0901/214417.854069:VERBOSE1:eligible_ad_notifications.cc(92)]   food & drink-vegetarian
[13478:13478:0901/214417.855077:VERBOSE1:eligible_ad_notifications.cc(103)] No eligible ads for parent-child segments
[13478:13478:0901/214417.855224:VERBOSE1:eligible_ad_notifications.cc(124)] Get eligible ads for parent segments:
[13478:13478:0901/214417.855272:VERBOSE1:eligible_ad_notifications.cc(126)]   personal finance
[13478:13478:0901/214417.855470:VERBOSE1:eligible_ad_notifications.cc(126)]   home
[13478:13478:0901/214417.855530:VERBOSE1:eligible_ad_notifications.cc(126)]   food & drink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzhaller moritzhaller Awaiting requested review from moritzhaller

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging this pull request may close these issues.

Follow up to #17670: Blocking parent-child segment will also block parent segment
3 participants
@tmancey @btlechowski @moritzhaller