Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes follow up to #17670: Blocking parent-child segment will also block parent segment - 1.30.x #9932

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Fixes follow up to #17670: Blocking parent-child segment will also block parent segment - 1.30.x #9932

merged 1 commit into from
Sep 2, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 31, 2021 •
edited by kjozwiak
Loading

Uplift of #9912
Resolves brave/brave-browser#17738

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team August 31, 2021 21:33
@tmancey tmancey self-assigned this Aug 31, 2021
@tmancey tmancey added this to the 1.30.x - Beta milestone Aug 31, 2021
@tmancey tmancey closed this Sep 1, 2021
@tmancey tmancey changed the title Fixes follow up to #17670: Blocking parent-child segment will also block parent segment Fixes follow up to #17670: Blocking parent-child segment will also block parent segment - 1.30.x Sep 1, 2021
@tmancey tmancey reopened this Sep 1, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Sep 1, 2021

Restarting post-init due to timing out as per https://ci.brave.com/job/pr-brave-browser-issues-17738-1.30.x-post-init/2/execution/node/102/log/.

14:18:04  Cannot contact i-031d3861079ac4dfb-linux-swarm-bb0409be: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@5133cd9b:JNLP4-connect connection from ip-172-31-59-3.us-west-2.compute.internal/172.31.59.3:54444": Remote call on JNLP4-connect connection from ip-172-31-59-3.us-west-2.compute.internal/172.31.59.3:54444 failed. The channel is closing down or has closed down
14:19:01  Could not connect to i-031d3861079ac4dfb-linux-swarm-bb0409be to send interrupt signal to process

kjozwiak
kjozwiak approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.30.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9912 (comment).

@kjozwiak kjozwiak merged commit b4c8404 into 1.30.x Sep 2, 2021
@kjozwiak kjozwiak deleted the issues/17738-1.30.x branch September 2, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak