Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #4256: Update unit tests for the new dtoi param duration. #4285

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Ref #4256: Update unit tests for the new dtoi param duration. #4285

merged 1 commit into from
Oct 5, 2021

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Oct 5, 2021 •
edited
Loading

Summary of Changes

No idea how CI passed for the previous PR

This pull request fixes #4256

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.32 milestone Oct 5, 2021
@iccub iccub requested a review from a team October 5, 2021 15:56
@iccub iccub merged commit c95abe4 into development Oct 5, 2021
@iccub iccub deleted the bugfix/4256_2 branch October 5, 2021 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.32.1
Development

Successfully merging this pull request may close these issues.

Change dtoi expiration to 30 days
2 participants
@iccub @kylehickinson