Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fetch custom urls #23

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 22, 2020

Resolves brave/brave-browser#12281

Test Plan:

  • Clean profile
  • Enable Rewards
  • Visit https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A
  • Open Rewards Panel and confirm that Lauren Rees is shown
  • Click Youtube logo at top of page
  • Click on a creator's name that points to a custom URL (you can check if it's a custom URL by hovering over the creator name and looking at the gray status bar in the bottom left of the browser window - if the URL starts like this https://youtube.com/c/... it's a custom URL)
  • Open Rewards panel and confirm that creator's name is shown and not Lauren Rees

@emerick emerick self-assigned this Oct 22, 2020
const channelId = utils.getChannelIdFromChannelPage(document.scripts)
sendPublisherInfoForChannel(channelId)
// Otherwise, it's a custom url which is handled just like a user url
sendPublisherInfoForUser()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is getChannelIdFromChannelPage no longer used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, removed.

@emerick emerick force-pushed the rewards-youtube-wrong-publisher branch from 47df59f to 1de3648 Compare October 22, 2020 20:30
@emerick emerick merged commit 62b7498 into master Oct 26, 2020
@emerick emerick deleted the rewards-youtube-wrong-publisher branch October 26, 2020 13:18
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.18.10 Chromium: 86.0.4240.111 (Official Build) nightly (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.15.7 (Build 19H2)

Looks good on staging 👍 Started https://ci.brave.com/view/all-extensions/job/brave-core-ext-local-data-files-update-publish-dev/23/. Once the new component finished building, launched Brave via the following:

/Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --vmodule=brave_component=2 --use-dev-goupdater-url --rewards=staging=true --brave-ads-staging

Ensured that the new component was pulled/downloaded as per the following:

[42611:775:1026/153546.580266:VERBOSE2:brave_component.cc(59)] component ready: {
   "description": "Brave Local Data Files Updater extension",
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAs4TIQXRCftLpGmQZxmm6AU8pqGKLoDyi537HGQyRKcK7j/CSXCf3vwJr7xkV72p7bayutuzyNZ3740QxBPiesfBOp8bBb8d2VgTHP3b+SuNmK/rsSRsMRhT05x8AAr/7ab6U3rW0Gsalm2653xnnQS8vt0s62xQTmC+UMXowaSLUZ0Be/TOu6lHZhOeo0NBMKc6PkOu0R1EEfP7dJR6SM/v4dBUBZ1HXcuziVbCXVyU51opZCMjlxyUlQR9pTGk+Zh5sDn1Vw1MwLnWiEfQ4EGL1V7GeI4vgLoOLgq7tmhEratHGCfC1IHm9luMACRr/ybMI6DQJOvgBvecb292FxQIDAQAB",
   "manifest_version": 2,
   "name": "Brave Local Data Files Updater",
   "version": "1.0.39"
}

@LaurenWags
Copy link
Member

Verified passed on macOS 10.14.6 using

Brave | 1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.14.6 (Build 18G6032)

Confirmed expected component (using --use-dev-goupdater-url flag):

[6604:775:1026/154251.384851:VERBOSE2:brave_component.cc(59)] component ready: {
   "description": "Brave Local Data Files Updater extension",
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAs4TIQXRCftLpGmQZxmm6AU8pqGKLoDyi537HGQyRKcK7j/CSXCf3vwJr7xkV72p7bayutuzyNZ3740QxBPiesfBOp8bBb8d2VgTHP3b+SuNmK/rsSRsMRhT05x8AAr/7ab6U3rW0Gsalm2653xnnQS8vt0s62xQTmC+UMXowaSLUZ0Be/TOu6lHZhOeo0NBMKc6PkOu0R1EEfP7dJR6SM/v4dBUBZ1HXcuziVbCXVyU51opZCMjlxyUlQR9pTGk+Zh5sDn1Vw1MwLnWiEfQ4EGL1V7GeI4vgLoOLgq7tmhEratHGCfC1IHm9luMACRr/ybMI6DQJOvgBvecb292FxQIDAQAB",
   "manifest_version": 2,
   "name": "Brave Local Data Files Updater",
   "version": "1.0.39"
}

Confirmed 1.0.39 listed for Brave Local Data Updater under brave://components:
Screen Shot 2020-10-26 at 3 53 27 PM

Verified STR from brave/brave-browser#12281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong publisher in Rewards Panel on youtube
5 participants