-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always fetch custom urls #23
Conversation
const channelId = utils.getChannelIdFromChannelPage(document.scripts) | ||
sendPublisherInfoForChannel(channelId) | ||
// Otherwise, it's a custom url which is handled just like a user url | ||
sendPublisherInfoForUser() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is getChannelIdFromChannelPage
no longer used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, removed.
47df59f
to
1de3648
Compare
Verification PASSED on
Looks good on
Ensured that the new component was pulled/downloaded as per the following:
|
Verified passed on
Confirmed expected component (using
Confirmed Verified STR from brave/brave-browser#12281 |
Resolves brave/brave-browser#12281
Test Plan:
https://youtube.com/c/...
it's a custom URL)