Wrong publisher in Rewards Panel on youtube

[btlechowski]

Sometimes previous publisher shows up in Rewards Panel

Note: This is a regression introduced in 1.16.x

Steps to Reproduce

1. Clean profile
2. Enable Rewards on staging
3. Open https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A
4. Open Rewards Panel
5. Click Youtube logo on youtube page
6. Click on a creators name that has a custom youtube URL (e.g. https://www.youtube.com/c/Mixes)
7. Open Rewards Panel

Note: Best to check the recording

Note: Proper publisher is shown after page reload

Actual result:

Wrong publisher in Rewards Panel

Expected result:

Proper publisher in Rewards Panel

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Reproducible on

Brave	1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	Ubuntu 18.04 LTS

Brave	1.17.45 Chromium: 86.0.4240.99 (Official Build) dev (64-bit)
Revision	002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS	Ubuntu 18.04 LTS

Brave	1.18.5 Chromium: 86.0.4240.111 (Official Build) nightly (64-bit)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	Ubuntu 18.04 LTS

Not reproducible on

Brave	1.15.76 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @NejcZdovc

[emerick]

I think this is happening when you go from a YouTube channel page to a custom YouTube URL. We saw something similar with YouTube user URLs during development. YouTube was updating the page on navigation, but certain DOM elements that we relied on for determining where we were (like scripts) remained the same and so were pointing to old data post-navigation. The fix is to always fetch custom URLs, just like we do user URLs.

[emerick]

Fix will be available in Greaselion 1.0.33.

[kjozwiak]

@LaurenWags and myself ran through the above on staging as per brave/brave-site-specific-scripts#23 (comment) & brave/brave-site-specific-scripts#23 (comment). Pushing these changes live.

Fix will be available in Greaselion 1.0.33.

5:58:35  Updating tag for Brave-Local-Data-Files-Updater: Brave-Local-Data-Files-Updater = 1.0.33

As per @emerick, new component should be Brave Local Data Updater - Version: 1.0.33.

[btlechowski]

Verification passed on

Brave	1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	Ubuntu 18.04 LTS

Brave Local Data Updater - Version: 1.0.33

Verified test plan from brave/brave-site-specific-scripts#23

Verified proper publisher is shown for https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A

Verified that after browsing youtube, proper publisher is shown for custom youtube url

---

Verification passed on

Brave | 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

Brave Local Data Updater - Version: 1.0.33

Verified test plan from brave/brave-site-specific-scripts#23

Verified proper publisher is shown for https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A

Verified that after browsing youtube, proper publisher is shown for custom youtube url

---

Verified passed with

Brave | 1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.14.6 (Build 18G6032)

Confirmed expected component version from #12281 (comment)

Verified test plan from brave/brave-site-specific-scripts#23
Verified STR from description

Confirmed expected information in the panel initially:

Confirmed expected information in the panel after navigating to a custom URL:

Confirmed expected information in the panel after browsing around a bit and using back/forward navigation arrows: