Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency prettier to v3 #1107

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Update dependency prettier to v3 #1107

merged 2 commits into from
Sep 13, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 9, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 2.8.8 -> 3.0.3 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.0.3

Compare Source

diff

Add preferUnplugged: true to package.json (#​15169 by @​fisker and @​so1ve)

Prettier v3 uses dynamic imports, user will need to unplug Prettier when Yarn's PnP mode is enabled, add preferUnplugged: true to package.json, so Yarn will install Prettier as unplug by default.

Support shared config that forbids require() (#​15233 by @​fisker)

If an external shared config package is used, and the package exports don't have require or default export.

In Prettier 3.0.2 Prettier fails when attempt to require() the package, and throws an error.

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in <packageName>/package.json
Allow argument of require() to break (#​15256 by @​fisker)
// Input
const plugin = require(
  global.STANDALONE
    ? path.join(__dirname, "../standalone.js")
    : path.join(__dirname, "..")
);

// Prettier 3.0.2
const plugin = require(global.STANDALONE
  ? path.join(__dirname, "../standalone.js")
  : path.join(__dirname, ".."));

// Prettier 3.0.3
const plugin = require(
  global.STANDALONE
    ? path.join(__dirname, "../standalone.js")
    : path.join(__dirname, "..")
);
Do not print trailing commas in arrow function type parameter lists in ts code blocks (#​15286 by @​sosukesuzuki)
<!-- Input -->
```ts
const foo = <T>() => {}
```

<!-- Prettier 3.0.2 -->
```ts
const foo = <T,>() => {}
```

<!-- Prettier 3.0.3 -->
```ts
const foo = <T>() => {}
```
Support TypeScript 5.2 using / await using declaration (#​15321 by @​sosukesuzuki)

Support for the upcoming Explicit Resource Management feature in ECMAScript. using / await using declaration

{
   using foo = new Foo();
   await using bar = new Bar();
}

v3.0.2

Compare Source

diff

Break after = of assignment if RHS is poorly breakable AwaitExpression or YieldExpression (#​15204 by @​seiyab)
// Input
const { section, rubric, authors, tags } = await utils.upsertCommonData(mainData);

// Prettier 3.0.1
const { section, rubric, authors, tags } = await utils.upsertCommonData(
  mainData,
);

// Prettier 3.0.2
const { section, rubric, authors, tags } =
  await utils.upsertCommonData(mainData);
Do not add trailing comma for grouped scss comments (#​15217 by @​auvred)
/* Input */
$foo: (
	'property': (),
	// comment 1
	// comment 2
)

/* Prettier 3.0.1 */
$foo: (
  "property": (),
  // comment 1
  // comment 2,
);

/* Prettier 3.0.2 */
$foo: (
  "property": (),
  // comment 1
  // comment 2
);
Print declare and export keywords for nested namespace (#​15249 by @​sosukesuzuki)
// Input
declare namespace abc1.def {}
export namespace abc2.def {}

// Prettier 3.0.1
namespace abc1.def {}
namespace abc2.def {}

// Prettier 3.0.2
declare namespace abc1.def {}
export namespace abc2.def {}

v3.0.1

Compare Source

diff

Fix cursor positioning for a special case (#​14812 by @​fisker)
// <|> is the cursor position

/* Input */
// All messages are represented in JSON.
// So, the prettier.py controls a subprocess which spawns "node {this_file}".
import {<|>  } from "fs"

/* Prettier 3.0.0 */
// All messages are represented in JSON.
// So, the prettier.py <|>controls a subprocess which spawns "node {this_file}".
import {} from "fs"

/* Prettier 3.0.1 */
// All messages are represented in JSON.
// So, the prettier.py controls a subprocess which spawns "node {this_file}".
import {<|>} from "fs"
Fix plugins/estree.d.ts to make it a module (#​15018 by @​kingyue737)

Add export {} in plugins/estree.d.ts to fix the "File is not a module" error

Add parenthesis around leading multiline comment in return statement (#​15037 by @​auvred)
// Input
function fn() {
  return (
    /**
     * @&#8203;type {...}
     */ expresssion
  )
}

// Prettier 3.0.0
function fn() {
  return /**
   * @&#8203;type {...}
   */ expresssion;
}

// Prettier 3.0.1
function fn() {
  return (
    /**
     * @&#8203;type {...}
     */ expresssion
  );
}
Add support for Vue "Generic Components" (#​15066 by @​auvred)

https://blog.vuejs.org/posts/vue-3-3#generic-components

<!-- Input -->
<script setup lang="ts" generic="T extends Type1 & Type2 & (Type3 | Type4), U extends string | number | boolean"></script>

<!-- Prettier 3.0.0 -->
<script
  setup
  lang="ts"
  generic="T extends Type1 & Type2 & (Type3 | Type4), U extends string | number | boolean"
></script>

<!-- Prettier 3.0.1 -->
<script
  setup
  lang="ts"
  generic="
    T extends Type1 & Type2 & (Type3 | Type4),
    U extends string | number | boolean
  "
></script>
Fix comments print in IfStatement (#​15076 by @​fisker)
function a(b) {
  if (b) return 1; // comment
  else return 2;
}

/* Prettier 3.0.0 */
Error: Comment "comment" was not printed. Please report this error!

/* Prettier 3.0.1 */
function a(b) {
  if (b) return 1; // comment
  else return 2;
}
Add missing type definition for printer.preprocess (#​15123 by @​so1ve)
export interface Printer<T = any> {
  // ...
+ preprocess?:
+   | ((ast: T, options: ParserOptions<T>) => T | Promise<T>)
+   | undefined;
}
Add missing getVisitorKeys method type definition for Printer (#​15125 by @​auvred)
const printer: Printer = {
  print: () => [],
  getVisitorKeys(node, nonTraversableKeys) {
    return ["body"];
  },
};
Add typing to support readonly array properties of AST Node (#​15127 by @​auvred)
// Input
interface TestNode {
  readonlyArray: readonly string[];
}

declare const path: AstPath<TestNode>;

path.map(() => "", "readonlyArray");

// Prettier 3.0.0
interface TestNode {
  readonlyArray: readonly string[];
}

declare const path: AstPath<TestNode>;

path.map(() => "", "readonlyArray");
//                  ^ Argument of type '"readonlyArray"' is not assignable to parameter of type '"regularArray"'. ts(2345)

// Prettier 3.0.1
interface TestNode {
  readonlyArray: readonly string[];
}

declare const path: AstPath<TestNode>;

path.map(() => "", "readonlyArray");
Add space before unary minus followed by a function call (#​15129 by @​pamelalozano)
// Input
div {
  margin: - func();
}

// Prettier 3.0.0
div {
  margin: -func();
}

// Prettier 3.0.1
div {
  margin: - func();
}

v3.0.0

Compare Source

diff

🔗 Release Notes


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jul 9, 2023
@socket-security
Copy link

socket-security bot commented Jul 9, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: prettier@2.8.8

@renovate renovate bot force-pushed the renovate/prettier-3.x branch 12 times, most recently from ad579d0 to 6c3d8fa Compare July 19, 2023 18:46
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 5 times, most recently from f1ff751 to c83d8a2 Compare July 25, 2023 14:34
@hadiamjad
Copy link
Contributor

@mrose17 I see this pre-commit error due to this update:

TypeError: _prettier.resolveConfig.sync is not a function
    at /Users/haadi/Downloads/renovo/brave-talk/node_modules/pretty-quick/dist/isSupportedExtension.js:12:30
    at Array.filter (<anonymous>)
    at _default (/Users/haadi/Downloads/renovo/brave-talk/node_modules/pretty-quick/dist/index.js:53:157)
    at Object.<anonymous> (/Users/haadi/Downloads/renovo/brave-talk/node_modules/pretty-quick/bin/pretty-quick.js:17:27)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47
husky - pre-commit hook exited with code 1 (error)

@mrose17
Copy link
Member

mrose17 commented Jul 26, 2023

OK, let's wait a week to see if "it fixes itself", e.g., in the same fashion as #1064

@renovate renovate bot force-pushed the renovate/prettier-3.x branch 7 times, most recently from 6d1f474 to 70fe22d Compare August 7, 2023 18:33
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 2 times, most recently from b6de628 to f7ef8e9 Compare August 9, 2023 12:47
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 2 times, most recently from b15d1e3 to 6a4eb9d Compare August 11, 2023 13:49
@hadiamjad
Copy link
Contributor

still see this error:
image

@renovate renovate bot force-pushed the renovate/prettier-3.x branch 7 times, most recently from 0c80e11 to e4ecb0a Compare August 22, 2023 12:07
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 2 times, most recently from 84a9daf to 4a9a904 Compare September 2, 2023 13:15
- v3 makes 'trailingComma' default to true (see [release notes](https://prettier.io/blog/2023/07/05/3.0.0.html#change-the-default-value-for-trailingcomma-to-all-11479httpsgithubcomprettierprettierpull11479-by-fiskerhttpsgithubcomfisker-13143httpsgithubcomprettierprettierpull13143-by-sosukesuzukihttpsgithubcomsosukesuzuki))
- v3 can also cause failures with it's automatic jest integration, just disable this in jest.config.js since we reformat on commit anyway
@renovate
Copy link
Contributor Author

renovate bot commented Sep 13, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great,t hanks!

@mrose17 mrose17 merged commit 51a1829 into main Sep 13, 2023
5 checks passed
@mrose17 mrose17 deleted the renovate/prettier-3.x branch September 13, 2023 20:22
mrose17 added a commit that referenced this pull request Sep 30, 2023
* Update all non-major dependencies (#1195)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update WelcomeScreen.tsx (#1205)

Remove check for Brave browser when creating a room.

* Update dependency node to v18.17.1 (#1208)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next to v23.4.2 (#1201)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (#1214)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency eslint-config-prettier to v9 (#1210)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (#1217)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update use-params.ts (#1219)

Change to make `?sol=y` as the default.  In a few weeks, we'll remove the query flag altogether.

* fix: correct prod location for labels-english (#1221)

as noted by @kdenhartog, this file should be sourced from talk.brave.com

* Updated: Implement web3 address exclusion behind a feature flag (#1215)

* address exclusion

* address exclusion

* address exclusion

* address exclusion

* minor touch-ups

1. restore EOL on last line of modified files.
2. use simplified Unicode \s in regex

* fix allow/deny address examples, update comments on query parameters

* Update ExceptionListPanel.tsx

courtesy of `npm run lint`

* Sync with `main` package*.json

* Update use-params.ts

Fix conflict from #1219

---------

Co-authored-by: Marshall T. Rose <mrose17@gmail.com>

* Update all non-major dependencies (#1225)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: repository housekeeping (#1237)

1. Add an `npm run check` command that runs all of the commonly failing checks: eslint, tsc, prettier and audit.

2. Run `check` as part of the CI build

3. Ensure linter and prettier run on the pre-commit hook

4. Fix the linter and formatting errors that had crept in while these checks were not enforced

* Update all non-major dependencies (#1227)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency prettier to v3 (#1107)

* Update dependency prettier to v3

* Update formatting based on prettier v3

- v3 makes 'trailingComma' default to true (see [release notes](https://prettier.io/blog/2023/07/05/3.0.0.html#change-the-default-value-for-trailingcomma-to-all-11479httpsgithubcomprettierprettierpull11479-by-fiskerhttpsgithubcomfisker-13143httpsgithubcomprettierprettierpull13143-by-sosukesuzukihttpsgithubcomsosukesuzuki))
- v3 can also cause failures with it's automatic jest integration, just disable this in jest.config.js since we reformat on commit anyway

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Graham Tackley <gtackley@brave.com>

* chore: configure eslint explicitly (#1243)

We used to rely on `eslint-config-react-app` to configure some aspects of eslint. This is the full-service config used by "Create React App". However it brings in other dependencies such as (an old version of) eslint itself. It also is much less maintained than it used to be, as many projects (including talk!) have moved away from using create-react-app.

Use the react specific plugins directly.

As part of this, eslint-plugin-react doesn't really like the style of declaring react functional components using `React.FC`. This is a bit of an outdated style anyway, and it's usually clearer just to create functions with explicit types. Since this is also how most react documentation sites do it, I've removed all uses of the `React.FC` type.

Co-authored-by: Marshall T. Rose <mrose17@gmail.com>

* Update typescript-eslint monorepo to v6 (#1136)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (#1242)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update aws-actions/configure-aws-credentials action to v4 (#1234)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update actions/checkout action to v4 (#1229)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency node to v18.18.0 (#1249)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marshall T. Rose <mrose17@gmail.com>

* Update all non-major dependencies (#1250)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* renovate.json: add org-level base (#1253)

* set `roomPasswordNumberOfDigits` to false to allow for alpanumeric passcodes

thank you @damencho

* Update all non-major dependencies (#1251) (#1256)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Graham Tackley <gtackley@brave.com>
Co-authored-by: Hadi Amjad <46374292+hadiamjad@users.noreply.github.com>
Co-authored-by: Andrea Brancaleoni <miwaxe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants