Alphanumeric passcodes #1257
Merged
Alphanumeric passcodes #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Remove check for Brave browser when creating a room.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Change to make `?sol=y` as the default. In a few weeks, we'll remove the query flag altogether.
as noted by @kdenhartog, this file should be sourced from talk.brave.com
* address exclusion * address exclusion * address exclusion * address exclusion * minor touch-ups 1. restore EOL on last line of modified files. 2. use simplified Unicode \s in regex * fix allow/deny address examples, update comments on query parameters * Update ExceptionListPanel.tsx courtesy of `npm run lint` * Sync with `main` package*.json * Update use-params.ts Fix conflict from #1219 --------- Co-authored-by: Marshall T. Rose <mrose17@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1. Add an `npm run check` command that runs all of the commonly failing checks: eslint, tsc, prettier and audit. 2. Run `check` as part of the CI build 3. Ensure linter and prettier run on the pre-commit hook 4. Fix the linter and formatting errors that had crept in while these checks were not enforced
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update dependency prettier to v3 * Update formatting based on prettier v3 - v3 makes 'trailingComma' default to true (see [release notes](https://prettier.io/blog/2023/07/05/3.0.0.html#change-the-default-value-for-trailingcomma-to-all-11479httpsgithubcomprettierprettierpull11479-by-fiskerhttpsgithubcomfisker-13143httpsgithubcomprettierprettierpull13143-by-sosukesuzukihttpsgithubcomsosukesuzuki)) - v3 can also cause failures with it's automatic jest integration, just disable this in jest.config.js since we reformat on commit anyway --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Graham Tackley <gtackley@brave.com>
We used to rely on `eslint-config-react-app` to configure some aspects of eslint. This is the full-service config used by "Create React App". However it brings in other dependencies such as (an old version of) eslint itself. It also is much less maintained than it used to be, as many projects (including talk!) have moved away from using create-react-app. Use the react specific plugins directly. As part of this, eslint-plugin-react doesn't really like the style of declaring react functional components using `React.FC`. This is a bit of an outdated style anyway, and it's usually clearer just to create functions with explicit types. Since this is also how most react documentation sites do it, I've removed all uses of the `React.FC` type. Co-authored-by: Marshall T. Rose <mrose17@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Marshall T. Rose <mrose17@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…sscodes thank you @damencho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.