This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Min page time and min visit selections are not being saved in Advanced Settings #11260
Assignees
Labels
Milestone
Comments
|
This was reported as issue#6 in #11037 (comment) and should have been fixed as it wasn't mentioned in #11037 (comment). |
bsclifton
pushed a commit
that referenced
this issue
Oct 4, 2017
…BAT Mercury. Details: Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards. This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x Merge pull request #10164 from luixxiul/polish-hideLower Replace hideLower with showLess f0d9c3d Merge pull request #10441 from brave/10322 add support for legacy ledger settings 052277d Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes) Auditors: @NejcZdovc, @luixxiul, @cezaraugusto Fixes #11261 Fixes #11260 Fixes #11250 Fixes #11246 Fixes #11263
bsclifton
pushed a commit
that referenced
this issue
Oct 4, 2017
…BAT Mercury. Details: Because the settings were renamed, git didn't properly handle changes when cherry-picking backwards. This caused the code in 0.19.x and 0.20.x to use the naming from 0.21.x Merge pull request #10164 from luixxiul/polish-hideLower Replace hideLower with showLess f0d9c3d Merge pull request #10441 from brave/10322 add support for legacy ledger settings 052277d Also includes fixes from 9ad7b4f (most of this commit was already backported, just grabbed the settings migration fixes) Auditors: @NejcZdovc, @luixxiul, @cezaraugusto Fixes #11261 Fixes #11260 Fixes #11250 Fixes #11246 Fixes #11263
|
Fixed with be048b8 |
|
Minimum visits for publisher relevancy is not saving. Gif is of update from 0.18.36 to 0.19.28, but this also happens on a clean profile with 0.19.28: I reproduced on MacOS, @srirambv repro'd on Windows. |
|
confirmed on Debian |
bsclifton
added a commit
that referenced
this issue
Oct 4, 2017
… missed with be048b8 Fixes #11260 Auditors: @luixxiul Test Plan: 1. Visit about:preferences and open the payments tab 2. Enable payments and click the gear in the top right (settings) 3. Change visit to something other than its existing value 4. Exit and re-open advanced settings again 5. Setting retained its value
bsclifton
added a commit
that referenced
this issue
Oct 4, 2017
… missed with be048b8 Fixes #11260 Auditors: @luixxiul Test Plan: 1. Visit about:preferences and open the payments tab 2. Enable payments and click the gear in the top right (settings) 3. Change visit to something other than its existing value 4. Exit and re-open advanced settings again 5. Setting retained its value
|
Fixed with d266f64 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
If you update the Minimum page time before logging a visit and the Minimum visits for publisher relevancy drop lists in Advanced Settings, and go back into Advanced Settings, you can see that your selections were not retained.
Steps to Reproduce
Actual result:
Expected result:
Selections should be maintained as they were in 0.18.36:
Reproduces how often: [What percentage of the time does it reproduce?] 100%
Brave Version
about:brave info:
Brave | 0.19.27
rev | e7f3a69
Muon | 4.4.25
Reproducible on current live release:
no
Additional Information
Reproduced by @srirambv on Windows.
cc: @kjozwiak
The text was updated successfully, but these errors were encountered: