add support for legacy ledger settings

[cezaraugusto]

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Test Plan:

npm run test -- --grep="runPreMigrations"

Manual test plan:

• Go to payments tab, enable and:

before checking this PR

1. set auto-incude to OFF
2. set Show only included sites to ON
3. click the gear on top-right
4. set Minimum page time before logging a visit to 8 seconds
5. set Minimum visits for publisher relevancy to 10 visits
6. set Allow contributions to non-verified sites to false
7. scroll down publishers list, toggle the bottom button to show more sites (button now says show less)

checkout this pr
ensure the above data is persisted:

1. auto-incude is OFF
2. Show only included sites is ON
3. Minimum page time before logging a visit is 8 seconds
4. Minimum visits for publisher relevancy is 10 visits
5. Allow contributions to non-verified sites is false
6. scroll down publishers list, bottom button should say show less

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[codecov-io]

Codecov Report

Merging #10441 into master will increase coverage by 0.41%.
The diff coverage is 61.9%.

@@            Coverage Diff             @@
##           master   #10441      +/-   ##
==========================================
+ Coverage   53.81%   54.23%   +0.41%     
==========================================
  Files         238      244       +6     
  Lines       21054    21122      +68     
  Branches     3258     3262       +4     
==========================================
+ Hits        11330    11455     +125     
+ Misses       9724     9667      -57

Flag	Coverage Δ
#unittest	54.23% <61.9%> (+0.41%)	⬆️

Impacted Files	Coverage Δ
js/constants/appConfig.js	100% <ø> (ø)	⬆️
js/constants/settings.js	100% <ø> (ø)	⬆️
js/settings.js	96.92% <100%> (-0.22%)	⬇️
app/sessionStore.js	64.68% <60%> (-0.43%)	⬇️
app/channel.js	85% <0%> (-7.31%)	⬇️
app/renderer/reducers/frameReducer.js	26.31% <0%> (-1.67%)	⬇️
app/browser/reducers/historyReducer.js	98.87% <0%> (-1.13%)	⬇️
js/stores/windowStore.js	29.77% <0%> (-0.84%)	⬇️
app/renderer/components/common/browserButton.js	69.04% <0%> (-0.72%)	⬇️
... and 40 more

[cezaraugusto]

xoxo codecov

[luixxiul]

The test plan works. Thanks for taking this!

[bsclifton]

OK wow- this was a little bit of a mess, but glad we're fixing it up 😄 I added a commit which cleans things up a bit more.

Cezar, there is a section I think you can move your change over to (where I have made similar changes 😄 ). Please take a look at

browser-laptop/js/settings.js

Lines 43 to 52 in f240074

	// Retrofit a new setting based on old values; we don't want to lose existing user settings.
	const getDefaultSetting = (settingKey, settingsCollection) => {
	switch (settingKey) {
	case settings.ACTIVE_PASSWORD_MANAGER:
	return passwordManagerDefault(settingKey, settingsCollection)
	case settings.BOOKMARKS_TOOLBAR_MODE:
	return bookmarksBarDefault(settingKey, settingsCollection)
	}
	return undefined
	}

[bsclifton]

On second thought... I think it's just fine how you implemented it 😄 We can revisit this with #10488

[darkdh]

++ except missing delete legacy addressed in 9ad7b4f

[bsclifton]

We're running into issues and unfortunately, this PR is causing issues with the BAT Mercury work (since settings were renamed). I'm going to pull this into 0.19.x

[bsclifton]

master 052277d
0.20.x 3bc7c1f
0.19.x be048b8