Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replace close button on downloadBar with SVG button #6070

Closed
luixxiul opened this issue Dec 7, 2016 · 2 comments · Fixed by #6071 or #6153
Closed

Replace close button on downloadBar with SVG button #6070

luixxiul opened this issue Dec 7, 2016 · 2 comments · Fixed by #6071 or #6153
Labels
misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 7, 2016

Describe the issue you encountered:
close1

Expected behavior:
close2

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version: master branch

  • Any related issues:
@luixxiul luixxiul mentioned this issue Dec 7, 2016
Merged
4 tasks
@luixxiul luixxiul added this to the 0.13.1 milestone Dec 8, 2016
@bsclifton bsclifton modified the milestones: 0.13.0, 0.13.1 Dec 8, 2016
@luixxiul luixxiul mentioned this issue Dec 16, 2016
Merged
4 tasks
@luixxiul luixxiul reopened this Dec 16, 2016
@luixxiul
Copy link
Contributor Author

Reopened as it is broken on the master branch for now:

downloadbar0

created the PR to fix it: #6153

This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
cezaraugusto pushed a commit that referenced this issue Dec 20, 2016
@cezaraugusto
Replaced fa-times for close button on download bar with SVG button (r…
e6b2818 
…edo #6071)

Closes #6070

Fixes 2c55150
The close button implemented fa-times on the download bar has been replaced with the SVG button with the PR: #6071

Auditors: @bridiver @bbondy

Test Plan:
1. Download a file
2. Make sure the download button is replaced with the SVG button on #6071
3. Make sure automated test passes
@alexwykoff alexwykoff mentioned this issue Dec 21, 2016
Closed
@luixxiul luixxiul mentioned this issue Dec 21, 2016
Closed
@luixxiul
Copy link
Contributor Author

Test Plan:

  1. Download a file
  2. Make sure the download button is replaced with the SVG button on Replaced fa-times for close button on download bar with SVG button #6071
  3. Make sure automated test passes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
3 participants
@luixxiul @bsclifton @srirambv