This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Replaced fa-times for close button on download bar with SVG button #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6070 Auditors: @bbondy @bradleyrichter Test Plan: 1. Download something 2. Make sure the close button on the download bar works
luixxiul
commented
Dec 7, 2016
| @@ -132,7 +132,17 @@ | |||
| margin: auto 0; | |||
|
|
|||
| .downloadButton { | |||
| margin: 0 2px; | |||
| background: url('../img/toolbar/close_download_btn.svg') center no-repeat; | |||
| background-size: 14px 14px; | |||
There was a problem hiding this comment.
@bradleyrichter Are these too large?
4 tasks
bradleyrichter
added a commit
that referenced
this pull request
Dec 16, 2016
…olbar Replaced fa-times for close button on download bar with SVG button (redo #6071)
This was referenced Dec 20, 2016
cezaraugusto
pushed a commit
that referenced
this pull request
Dec 20, 2016
…edo #6071) Closes #6070 Fixes 2c55150 The close button implemented fa-times on the download bar has been replaced with the SVG button with the PR: #6071 Auditors: @bridiver @bbondy Test Plan: 1. Download a file 2. Make sure the download button is replaced with the SVG button on #6071 3. Make sure automated test passes
|
Labelled |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Closes #6070
Auditors: @bbondy @bradleyrichter
Test Plan: