Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replace data-test-id with testId in <Button> #8090

Closed
luixxiul opened this issue Apr 5, 2017 · 0 comments
Closed

Replace data-test-id with testId in <Button> #8090

luixxiul opened this issue Apr 5, 2017 · 0 comments
Assignees
@luixxiul
Labels
automated-tests misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 5, 2017 •
edited
Loading

Test Plan

#8091 (comment)

Describe the issue you encountered: Replace data-test-id with testId in <Button>.

  • Any related issues:
@luixxiul luixxiul self-assigned this Apr 5, 2017
@luixxiul luixxiul mentioned this issue Apr 5, 2017
Merged
4 tasks
@luixxiul luixxiul added this to the 0.14.2 milestone Apr 6, 2017
bridiver pushed a commit that referenced this issue Apr 6, 2017
@bridiver
Replaced other test ids in Buttons
7a11a8e 
Also: modified classNames with cx.

Closes #8090

Auditors:

Test Plan:
1. Open the browser
2. Check for update
3. Make sure the buttons work
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
automated-tests misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @cezaraugusto @srirambv