Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replaced other test ids in Buttons #8091

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Replaced other test ids in Buttons #8091

merged 1 commit into from
Apr 6, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 5, 2017

Also: modified classNames with cx.

Closes #8090

Auditors:

Test Plan:

  1. Open the browser
  2. Check for update
  3. Make sure the buttons work
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Also: modified classNames with cx.

Closes #8090

Auditors:

Test Plan:
1. Open the browser
2. Check for update
3. Make sure the buttons work
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luixxiul luixxiul merged commit ef9d2be into brave:master Apr 6, 2017
@luixxiul luixxiul added this to the 0.14.2 milestone Apr 6, 2017
@luixxiul luixxiul deleted the fix-braveShieldButton branch April 6, 2017 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants