Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

button styling on about:safebrowsing #8945

Closed
luixxiul opened this issue May 19, 2017 · 0 comments · Fixed by #9026
Closed

button styling on about:safebrowsing #8945

luixxiul opened this issue May 19, 2017 · 0 comments · Fixed by #9026
Assignees
@luixxiul
Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified
Milestone
0.17.13 (Release ...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 19, 2017 •
edited
Loading

Test plan

#9026 (comment)

Describe the issue you encountered:
#8923 (comment)

side note @luixxiul could you please fix this one, I saw it while testing this PR. Button is jumping around 😄

18

  • Brave Version (revision SHA): 77140b9

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul added this to the 0.15.400 milestone May 19, 2017
@luixxiul luixxiul self-assigned this May 19, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@luixxiul luixxiul mentioned this issue May 24, 2017
Merged
7 tasks
@luixxiul luixxiul modified the milestones: 0.16.100, 0.16.200 May 24, 2017
@cezaraugusto cezaraugusto mentioned this issue May 30, 2017
Closed
cezaraugusto pushed a commit that referenced this issue May 30, 2017
@cezaraugusto
Fix margin around the button on about:safebrowsing
ce6613c 
Closes #8945
Addresses #9025

Auditors:

Test Plan:
1. Open downloadme.org
2. Click "Advanced" button
3. Click "Hide advanced" button
4. Make sure the button does not move
This was referenced Jun 19, 2017
Closed
Closed
Closed
Closed
@Jacalz Jacalz mentioned this issue Jun 21, 2017
Closed
94 tasks
@alexwykoff alexwykoff mentioned this issue Jun 22, 2017
Closed
@LaurenWags LaurenWags mentioned this issue Jun 23, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix margin around the button on about:safebrowsing & Add browserButton_subtleItem fixing regressions
4 participants
@alexwykoff @luixxiul @srirambv @LaurenWags