Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

workaround to fix about:safebrowsing redirect #8923

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 17, 2017

fix #8905. this is a workaround for the underlying issue, which is that the l20n.min.js resource is blocked when about:safebrowsing is redirected to from a remote page instead of loaded directly.

Test Plan:

  1. safebrowsing test should pass
  2. go to downloadme.org. it should redirect to the safebrowsing page and the page should not be blank or have missing text.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #8905

Test Plan:
1. safebrowsing test should pass
2. go to downloadme.org. it should redirect to the safebrowsing page and the page should not be blank or have missing text.
@diracdeltas diracdeltas self-assigned this May 17, 2017
@diracdeltas diracdeltas added this to the 0.15.300 milestone May 17, 2017
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both manual test plan and automated test work. LGTM.

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc
Copy link
Contributor

side note @luixxiul could you please fix this one, I saw it while testing this PR. Button is jumping around 😄

18

@bbondy
Copy link
Member

bbondy commented May 18, 2017

++

@bbondy bbondy merged commit 77140b9 into master May 18, 2017
@bsclifton bsclifton deleted the fix/safebrowsing branch May 18, 2017 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

about:safebrowsing shows a blank page
4 participants