Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Middle click on pinned tab causes all opened tabs to show as pinned tabs #9492

Closed
srirambv opened this issue Jun 15, 2017 · 2 comments · Fixed by #9528
Closed

Middle click on pinned tab causes all opened tabs to show as pinned tabs #9492

srirambv opened this issue Jun 15, 2017 · 2 comments · Fixed by #9528

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jun 15, 2017

Test plan

See #9528 (comment)

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Cloning a pinned tab and then middle click on it causes the cloned tab to get pinned but with close button

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.17.3
    rev 02a7878
    Muon 4.0.3

  • Steps to reproduce:

    1. Open 3-4 tabs and visit pages in them and pin them
    2. Right click on the 2nd pinned tab and click on clone, ensure the cloned tab is opened
    3. Middle click/Mouse wheel click on any pinned tab, cloned tab gets pinned but shows close button on it. Switching to it causes it to go back to being normal tab
  • Actual result:
    Cloning a pinned tab and then middle click on it causes the cloned tab to get pinned but with close button

  • Expected result:
    Cloned tab should remain normal and not become a pinned tab

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No, verified on 0.16.9 doesn't happen. Introduced from 0.17.1 onwards

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    No console errors
    tabpin

  • Any related issues:
    cc: @NejcZdovc @bsclifton @cezaraugusto

@srirambv srirambv added this to the 0.18.x (Developer Channel) milestone Jun 15, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.17.x (Beta Channel), 0.18.x (Developer Channel) Jun 15, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 15, 2017
@srirambv
Copy link
Collaborator Author

This happens on all normal tabs not just the cloned tabs. Mouse hover restore backs the tab to normal state

@srirambv srirambv changed the title Cloning a pinned tab and then middle click on it causes the cloned tab to get pinned but with close button Middle click on pinned tab causes all opened tabs to show as pinned tabs Jun 15, 2017
@NejcZdovc NejcZdovc assigned cezaraugusto and unassigned NejcZdovc Jun 15, 2017
cezaraugusto added a commit that referenced this issue Jun 16, 2017
Auditors: @bsclifton
Fix #9492
Test Plan: Middle click over pinnedTabs shouldn't be allowed
@cezaraugusto
Copy link
Contributor

  • Normal tabs goes to extraSmall breakpoint rather than getting pinned. That explains close button and normal state after hover (component update)
  • confirmed Sri last comment it happens to all tabs rather than only cloned tabs

Chrome, Safari, and FF all close pinned tabs with middle click. Opera does nothing.

Given closing a pinned tab is a matter for another issue, I'm going to cancel middle click over pinned tabs until #4063 is fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.