Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Take no action for middle click over pinned tabs #9528

Merged
merged 1 commit into from
Jun 17, 2017
Merged

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jun 16, 2017

Test plan

  1. Pin 2 tabs, have 1-2 unpinned
  2. Middle click over a pinned tab
  3. Should do nothing

Description

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Auditors: @bsclifton
Fix #9492

repeating comments left in #9492 (comment):

Middle click over pinnedTabs shouldn't be allowed until #4063 is solved. Doing it was leading to a weird update over tabs, setting unpinned tabs to the smallest breakpoint, which is visually similar to pinned tabs but with close button replacing icon while active.

for clarification, this pull-request copy the same behavior as Opera, which may not be our intention given FF, Chrome and Safari all close the tab. However, leave the discussion open until #4063.

/cc @srirambv

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Auditors: @bsclifton
Fix #9492
Test Plan: Middle click over pinnedTabs shouldn't be allowed
@cezaraugusto cezaraugusto added this to the 0.17.x (Beta Channel) milestone Jun 16, 2017
@cezaraugusto cezaraugusto self-assigned this Jun 16, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Nice fix 😄

Good find, @srirambv!

@bsclifton bsclifton merged commit 2bc6b7f into master Jun 17, 2017
@bsclifton bsclifton deleted the tabsbar/9492 branch June 17, 2017 07:42
bsclifton added a commit that referenced this pull request Jun 17, 2017
Take no action for middle click over pinned tabs
bsclifton added a commit that referenced this pull request Jun 17, 2017
Take no action for middle click over pinned tabs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middle click on pinned tab causes all opened tabs to show as pinned tabs
2 participants