Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Revert "Add accelerator keys to create new session tabs" #13042

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Revert "Add accelerator keys to create new session tabs" #13042

merged 1 commit into from
Feb 7, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Feb 6, 2018

Reverts #10364

Fix #12956

test plan (Windows):

  • visit site with an input box (duckduckgo.com)
  • Attempt to insert special character (altgr+3)
  • Observe character is inserted and new session tab is not opened

@petemill petemill added this to the 0.20.x Hotfix 2 (Referral Promotion) milestone Feb 6, 2018
@petemill petemill self-assigned this Feb 6, 2018
@vinicentus
Copy link

vinicentus commented Feb 6, 2018 •
edited
Loading

How about Cmd + Alt + partitionNumber for MacOS and Ctrl + Shift + partitionNumber for Windows and Linux?
#13015

@bsclifton
Copy link
Member

bsclifton commented Feb 7, 2018 •
edited
Loading

@vinicentus that is a good suggestion; however, it would still affect altgr. It is possible to detect alt vs altgr via event handlers (see here for an example:

browser-laptop/app/renderer/components/main/main.js

Line 147 in 6fb1ad5

if (e.location === keyLocations.DOM_KEY_LOCATION_RIGHT ||

If electron/muon doesn't allow for distinguishing between alt and altgr, that might have to be the route taken

disregard my comments- just now noticed that you're proposing ctrl + shift for Windows/Linux 😄

@rasved rasved mentioned this pull request Feb 7, 2018
Closed
NejcZdovc
NejcZdovc approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@petemill petemill merged commit 70cc900 into master Feb 7, 2018
petemill added a commit that referenced this pull request Feb 7, 2018
@petemill
Merge pull request #13042 from brave/revert-10364-session-accelerator…
c6b61ec 
…-shortcut

Revert "Add accelerator keys to create new session tabs"
petemill added a commit that referenced this pull request Feb 7, 2018
@petemill
Merge pull request #13042 from brave/revert-10364-session-accelerator…
caf84cf 
…-shortcut

Revert "Add accelerator keys to create new session tabs"
petemill added a commit that referenced this pull request Feb 7, 2018
@petemill
Merge pull request #13042 from brave/revert-10364-session-accelerator…
632d435 
…-shortcut

Revert "Add accelerator keys to create new session tabs"
@petemill petemill deleted the revert-10364-session-accelerator-shortcut branch February 7, 2018 19:17
@petemill
Copy link
Member Author

petemill commented Feb 7, 2018

0.22.x c6b61ec
0.21.x caf84cf
0.20.x 632d435

@enjikaka
Copy link

enjikaka commented Feb 9, 2018 •
edited
Loading

When is this to be released? Cannot respond to people in slack without opening new tabs all the time since @ in nordic keyboards is AltGr+2

@NejcZdovc
Copy link
Contributor

@enjikaka it's targeted for the next week

@vinicentus vinicentus mentioned this pull request Feb 11, 2018
Closed
@bsclifton bsclifton mentioned this pull request Feb 13, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@aekeus aekeus Awaiting requested review from aekeus

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@petemill petemill

Labels
OS/Windows regression
Projects
None yet
Milestone
0.20.x Release 2 (Referral Promotion)
Development

Successfully merging this pull request may close these issues.
5 participants
@petemill @vinicentus @bsclifton @enjikaka @NejcZdovc